Skip to content

Add trailing newline when dumping JSON to files#3539

Open
janEbert wants to merge 2 commits into
NVIDIA:mainfrom
janEbert:fix-json-dumps
Open

Add trailing newline when dumping JSON to files#3539
janEbert wants to merge 2 commits into
NVIDIA:mainfrom
janEbert:fix-json-dumps

Conversation

@janEbert
Copy link
Copy Markdown
Contributor

Add trailing newline when dumping JSON to files, just to better follow and satisfy POSIX standards. Sorry about the review notifications for such minuscule changes.

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@janEbert janEbert requested review from a team as code owners February 23, 2026 14:59
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team February 23, 2026 15:00
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Feb 23, 2026
Copy link
Copy Markdown
Contributor

@yobibyte yobibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a comment for every line? For me, the actual code is pretty obvious.

@janEbert
Copy link
Copy Markdown
Contributor Author

I was considering the same, but since the behavior wasn't followed previously and it doesn't take up additional lines, I thought it would be fine. I'm open to removing the comments, though.

Just to better follow and satisfy POSIX standards.
@janEbert janEbert added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants