fix: version-gate cgroup preflight check on openshell version#258
Closed
fix: version-gate cgroup preflight check on openshell version#258
Conversation
Only run the cgroup v2 / cgroupns=host check for openshell < 0.0.8. OpenShell v0.0.8 added internal cgroup v2 host namespace support (NVIDIA/OpenShell#329), making the NemoClaw-side check unnecessary for current versions. For users on older openshell, the check still runs and now recommends upgrading openshell as the primary fix.
Contributor
Author
|
Closing in favor of #248 — using the cgroup check removal as a forcing function to get users onto openshell v0.0.8+. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #248.
Summary
Problem
PR #248 proposed removing the cgroup check entirely since OpenShell v0.0.8 handles it upstream. But users on older openshell versions (e.g. 0.0.6) would hit cryptic k3s failures on cgroup v2 hosts (Ubuntu 24.04, DGX Spark) with no guidance on how to fix it — we saw this today on an H100.
Fix
Parse
openshell --version, compare against minimum0.0.8. If older, run the existingcheckCgroupConfig()check. If current, skip it.Keeps
bin/lib/preflight.jsandtest/preflight.test.jsintact (PR #248 deleted them).Test plan
node --test test/preflight.test.js— 13/13 passnode -e "require('./bin/lib/onboard')"— no import errors