-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(security): add binaries restrictions to all messaging and preset policies #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d3cd6df
fix(security): add binaries restrictions to all messaging and preset …
ericksoa 77c03c3
fix: add interpreter binaries to npm/pypi presets, strengthen test regex
ericksoa ecb2da2
fix: convert node:test to vitest in security-binaries-restriction.tes…
cv cad8cd0
Merge upstream/main into fix/messaging-binaries-restriction
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { describe, it, expect } from "vitest"; | ||
| import fs from "node:fs"; | ||
| import path from "node:path"; | ||
|
|
||
| const BASELINE = path.join(import.meta.dirname, "..", "nemoclaw-blueprint", "policies", "openclaw-sandbox.yaml"); | ||
| const PRESETS_DIR = path.join(import.meta.dirname, "..", "nemoclaw-blueprint", "policies", "presets"); | ||
|
|
||
| describe("binaries restriction: baseline policy", () => { | ||
| it("every network_policies entry has a binaries section", () => { | ||
| // Parse YAML manually (no yaml dependency) — find all top-level keys under network_policies | ||
| // and verify each has a "binaries:" line within its block | ||
| const yaml = fs.readFileSync(BASELINE, "utf-8"); | ||
| const lines = yaml.split("\n"); | ||
| let inNetworkPolicies = false; | ||
| let currentBlock = null; | ||
| const blocks = []; | ||
|
|
||
| for (let i = 0; i < lines.length; i++) { | ||
| const line = lines[i]; | ||
| if (/^network_policies:/.test(line)) { inNetworkPolicies = true; continue; } | ||
| if (inNetworkPolicies && /^\S/.test(line) && line.trim() !== "") { | ||
| if (currentBlock) blocks.push(currentBlock); | ||
| currentBlock = null; | ||
| inNetworkPolicies = false; | ||
| continue; | ||
| } | ||
| if (!inNetworkPolicies) continue; | ||
| // Top-level entry under network_policies (2-space indent, not a comment) | ||
| if (/^ (?!#)\S.*:\s*$/.test(line)) { | ||
| if (currentBlock) blocks.push(currentBlock); | ||
| currentBlock = { name: line.trim().replace(/:$/, ""), startLine: i + 1, lines: [line] }; | ||
| continue; | ||
| } | ||
| if (currentBlock) currentBlock.lines.push(line); | ||
| } | ||
| if (currentBlock) blocks.push(currentBlock); | ||
|
|
||
| expect(blocks.length).toBeGreaterThan(0); | ||
|
|
||
| const violators = blocks.filter(b => !b.lines.some(l => /^\s+binaries:/.test(l))); | ||
|
|
||
| expect(violators.map(b => b.name)).toEqual([]); | ||
| }); | ||
| }); | ||
|
|
||
| describe("binaries restriction: policy presets", () => { | ||
| it("every preset YAML has a binaries section", () => { | ||
| const presets = fs.readdirSync(PRESETS_DIR).filter(f => f.endsWith(".yaml")); | ||
| expect(presets.length).toBeGreaterThan(0); | ||
|
|
||
| const missing = []; | ||
| for (const file of presets) { | ||
| const content = fs.readFileSync(path.join(PRESETS_DIR, file), "utf-8"); | ||
| if (!/^\s+binaries:\s*$/m.test(content)) { | ||
| missing.push(file); | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
| } | ||
|
|
||
| expect(missing).toEqual([]); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This substring check would pass if
binaries:appeared in a YAML comment. The baseline test already does proper structure-aware parsing — this should be at least a regex match for a real YAML key: