fix: handle unbound BASH_SOURCE when install.sh is piped via curl#656
fix: handle unbound BASH_SOURCE when install.sh is piped via curl#656
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
curl -fsSL https://www.nvidia.com/nemoclaw.sh | bashfails withBASH_SOURCE[0]: unbound variablebecauseBASH_SOURCEis empty when piped andset -utreats it as unbound.Fix:
${BASH_SOURCE[0]:-$0}falls back to$0whenBASH_SOURCEis unset.Regression from #470.
Closes #655
Summary by CodeRabbit