Skip to content

fix(ci): use BuildKit secrets instead of build-arg for GITHUB_TOKEN #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drew merged 1 commit into from
Mar 15, 2026
Merged

fix(ci): use BuildKit secrets instead of build-arg for GITHUB_TOKEN #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ jobs:
uses: ./.github/actions/setup-buildx

- name: Build and push CI image
env:
MISE_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
docker buildx build \
--platform linux/amd64,linux/arm64 \
--build-arg MISE_GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }} \
--secret id=MISE_GITHUB_TOKEN,env=MISE_GITHUB_TOKEN \
--push \
-t ${{ env.CI_IMAGE }}:${{ github.sha }} \
-t ${{ env.CI_IMAGE }}:latest \
Expand Down
5 changes: 3 additions & 2 deletions deploy/docker/Dockerfile.ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ RUN curl https://mise.run | sh
COPY mise.toml /opt/mise/mise.toml
COPY tasks/ /opt/mise/tasks/
WORKDIR /opt/mise
ARG MISE_GITHUB_TOKEN
RUN mise trust /opt/mise/mise.toml && \
RUN --mount=type=secret,id=MISE_GITHUB_TOKEN \
export MISE_GITHUB_TOKEN="$(cat /run/secrets/MISE_GITHUB_TOKEN 2>/dev/null || true)" && \
mise trust /opt/mise/mise.toml && \
env -u RUSTC_WRAPPER mise install && \
/root/.cargo/bin/rustup component remove rust-docs || true && \
rm -rf /root/.rustup/toolchains/*/share/doc /root/.rustup/toolchains/*/share/man
Expand Down
Loading