Skip to content

fix(sandbox): block direct inet sockets in proxy mode #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drew wants to merge 1 commit into from
Closed

fix(sandbox): block direct inet sockets in proxy mode #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions crates/openshell-sandbox/src/sandbox/linux/seccomp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ pub fn apply(policy: &SandboxPolicy) -> Result<()> {
return Ok(());
}

let allow_inet = matches!(policy.network.mode, NetworkMode::Proxy);
let filter = build_filter(allow_inet)?;
let filter = build_filter()?;

// Required before applying seccomp filters.
let rc = unsafe { libc::prctl(libc::PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) };
Expand All @@ -34,15 +33,17 @@ pub fn apply(policy: &SandboxPolicy) -> Result<()> {
Ok(())
}

fn build_filter(allow_inet: bool) -> Result<seccompiler::BpfProgram> {
fn build_filter() -> Result<seccompiler::BpfProgram> {
let mut rules: BTreeMap<i64, Vec<SeccompRule>> = BTreeMap::new();

let mut blocked_domains = vec![libc::AF_PACKET, libc::AF_BLUETOOTH, libc::AF_VSOCK];
if !allow_inet {
blocked_domains.push(libc::AF_INET);
blocked_domains.push(libc::AF_INET6);
blocked_domains.push(libc::AF_NETLINK);
}
let blocked_domains = vec![
libc::AF_PACKET,
libc::AF_BLUETOOTH,
libc::AF_VSOCK,
libc::AF_INET,
libc::AF_INET6,
libc::AF_NETLINK,
];

for domain in blocked_domains {
debug!(domain, "Blocking socket domain via seccomp");
Expand Down
Loading