Skip to content

fix(installer): remove duplicate app name in install output#408

Merged
drew merged 1 commit intomainfrom
cleanup-install-copy
Mar 17, 2026
Merged

fix(installer): remove duplicate app name in install output#408
drew merged 1 commit intomainfrom
cleanup-install-copy

Conversation

@drew
Copy link
Collaborator

@drew drew commented Mar 17, 2026

Summary

Clean up the install success message so it does not repeat the app name when --version already includes it. This keeps the installer output easier to read and avoids awkward duplicated text.

Related Issue

Changes

  • Remove the extra ${APP_NAME} prefix from the final install success log in install.sh
  • Preserve the existing installed binary path and version lookup behavior

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew requested a review from a team as a code owner March 17, 2026 21:30
@drew drew self-assigned this Mar 17, 2026
@drew drew merged commit cf66d05 into main Mar 17, 2026
14 checks passed
@drew drew deleted the cleanup-install-copy branch March 17, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants