Skip to content

fix(ci): use published install script in release workflows#416

Merged
drew merged 8 commits intomainfrom
update-relase-canary
Mar 18, 2026
Merged

fix(ci): use published install script in release workflows#416
drew merged 8 commits intomainfrom
update-relase-canary

Conversation

@drew
Copy link
Collaborator

@drew drew commented Mar 17, 2026

Summary

Switch release workflows to install the CLI via the published install.sh script (curl from GitHub) instead of the local checkout or gh CLI. Also adds a lightweight job to verify the default install path (no OPENSHELL_VERSION) resolves correctly.

Changes

  • release-canary.yml: Install via curl ... | OPENSHELL_VERSION=<tag> sh instead of running the local ./install.sh with env vars
  • release-canary.yml: Add install-default job that runs the install script without OPENSHELL_VERSION on both amd64/arm64 to verify the "resolve latest" codepath
  • release-tag.yml: Replace the gh release download install snippet in the release body with a one-liner: curl -LsSf ... | OPENSHELL_VERSION=<tag> sh

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

drew added 2 commits March 17, 2026 14:59
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
- Release canary: install via curl from published install.sh instead of
  local checkout, pinning OPENSHELL_VERSION inline
- Release canary: add install-default job to verify the default (latest)
  install path works without OPENSHELL_VERSION set
- Release tag: replace gh CLI install snippet in release body with
  one-liner install.sh command pinned to the release tag
@drew drew requested a review from a team as a code owner March 17, 2026 22:53
@drew drew self-assigned this Mar 17, 2026
pimlock
pimlock previously approved these changes Mar 17, 2026
@drew drew requested a review from pimlock March 17, 2026 23:57
@drew drew merged commit dcd9912 into main Mar 18, 2026
13 checks passed
@drew drew deleted the update-relase-canary branch March 18, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants