fix(cli): clear stale last-used sandbox on deletion#510
Open
Kh4L wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(cli): clear stale last-used sandbox on deletion#510Kh4L wants to merge 1 commit intoNVIDIA:mainfrom
Kh4L wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
When a sandbox is deleted, the locally stored last-used record now gets cleared if it matches the deleted sandbox name. This prevents subsequent commands from falling back to a sandbox that no longer exists, which previously caused confusing gRPC errors. Adds clear_last_sandbox_if_matches() to openshell-bootstrap and calls it from sandbox_delete() after each successful deletion. Closes NVIDIA#172 Signed-off-by: Serge Panev <spanev@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox connectfrom falling back to a deleted sandbox, which previously caused confusing gRPC "not found" errorsRelated Issue
Closes #172
Changes
crates/openshell-bootstrap/src/metadata.rs: addclear_last_sandbox_if_matches()that removes the persisted record when it matches the deleted sandbox namecrates/openshell-bootstrap/src/lib.rs: export the new functioncrates/openshell-cli/src/run.rs: callclear_last_sandbox_if_matches()after each successful sandbox deletion; addgatewayparameter tosandbox_delete()crates/openshell-cli/src/main.rs: pass gateway name through tosandbox_delete()Testing
mise run testpassesopenshell sandbox connect— should get a clean "no last-used sandbox" error instead of a gRPC crashChecklist