Skip to content

refactor(proto): rename UpdateSettings to UpdateConfig for consistency with read path#515

Merged
johntmyers merged 1 commit intomainfrom
chore/rename-update-settings-to-update-config
Mar 20, 2026
Merged

refactor(proto): rename UpdateSettings to UpdateConfig for consistency with read path#515
johntmyers merged 1 commit intomainfrom
chore/rename-update-settings-to-update-config

Conversation

@johntmyers
Copy link
Collaborator

Summary

Renames the UpdateSettings RPC to UpdateConfig to match the read-side naming (GetSandboxConfig, GetGatewayConfig). The RPC handles both settings and policy mutations, so UpdateConfig is more accurate.

Related Issue

Follow-up to #474 (PR review feedback)

Changes

  • Proto: UpdateSettingsUpdateConfig, UpdateSettingsRequest/ResponseUpdateConfigRequest/Response
  • Server: handler method update_settingsupdate_config
  • CLI, TUI, sandbox, e2e (Rust + Python): all call sites and mock trait impls updated

Mechanical rename across 17 files, no behavioral changes.

Testing

  • cargo build all affected crates
  • cargo test -p openshell-server -p openshell-core all passing
  • E2E tests (running in CI)

Checklist

  • Follows Conventional Commits
  • No behavioral changes

@johntmyers johntmyers requested a review from a team as a code owner March 20, 2026 23:08
@johntmyers johntmyers added the test:e2e Requires end-to-end coverage label Mar 20, 2026
@johntmyers johntmyers self-assigned this Mar 20, 2026
@johntmyers johntmyers merged commit bbcaed2 into main Mar 20, 2026
13 checks passed
@johntmyers johntmyers deleted the chore/rename-update-settings-to-update-config branch March 20, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants