fix(docker): enable dev-settings feature by default in local builds#523
Open
fix(docker): enable dev-settings feature by default in local builds#523
Conversation
Local image builds via mise run cluster / mise run docker:build:* were missing the dev-settings feature flag, causing e2e tests to fail with 'unknown setting key dummy_bool'. CI sets EXTRA_CARGO_FEATURES explicitly but the local path did not. Default EXTRA_CARGO_FEATURES to openshell-core/dev-settings so local builds match CI. The variable can still be overridden by the caller.
johntmyers
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local image builds (
mise run cluster,mise run docker:build:*) were missing thedev-settingsfeature flag, causing e2e tests to fail withunknown setting key 'dummy_bool'. CI setsEXTRA_CARGO_FEATURES=openshell-core/dev-settingsexplicitly indocker-build.yml, but the local build path never did.Related Issue
No issue — discovered while running e2e tests locally after #474 landed.
Changes
tasks/scripts/docker-build-image.sh: DefaultEXTRA_CARGO_FEATUREStoopenshell-core/dev-settingswhen not already set by the caller. This matches CI behavior and ensures test-only settings (dummy_bool,dummy_int) are compiled into local builds.The variable can still be overridden (
EXTRA_CARGO_FEATURES=foo mise run cluster) or cleared (EXTRA_CARGO_FEATURES="" mise run cluster) if needed.Testing
Checklist