[Common, PyTorch] Improve mHC to match DeepSeek's implementation#2978
Draft
kainzhong wants to merge 12 commits into
Draft
[Common, PyTorch] Improve mHC to match DeepSeek's implementation#2978kainzhong wants to merge 12 commits into
kainzhong wants to merge 12 commits into
Conversation
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
af685d7 to
eccba0c
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some enhancement for mHC to better align with DeepSeek's tilelang implementation: https://github.com/deepseek-ai/TileKernels/tree/main/tile_kernels/mhc
Fixes # (issue)
Type of change
Changes
mhc_generate_mix_and_aggregateAPI that does projection, scale, sinkhorn and aggregate togethermhc_fused_projectionto accept arguments with mixed dtype: x.dtype=bf16, phi.dtype=fp32, which matches DeepSeek's implementationmhc_fused_projectionnow outputs fp32 regardless of the input dtype, matching DeepSeek's implementationfuse_grad_x_accoptimization (default to False), which will reuse the same grad_x buffer to accumulate the initial mHC input x's gradient formhc_fused_expand_combine,mhc_fused_aggregateandmhc_fused_projectionnorm_weightformhc_fused_projection, which would be equivalent to apply RMSNorm in the unfused manner withelementwise_affine=True, which would be the learnable per-element affine parameters for RMSNormChecklist: