Fix USD volume range and skip NanoVDB grids with no active voxels #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
this PR fixes a bug that I've encountered when loading a large dataset composed by many nanovdbs. What happened is that when a nanovdb had no active voxel, it was rendered as a dark block.
With this PR I implemented a check that skips nanovdb volumes with no active voxel, effectively solving the problem. I think this should be fixed at source, not writing empty nanovdbs in the first place, however it is convenient in my opinion to also have this safety check in tsd.
@jeffamstutz @tarcila I'm happy to discuss the matter further if you would prefer a different solution
Have a great day,
A.