-
Notifications
You must be signed in to change notification settings - Fork 127
Clique Table and Preprocessing #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akifcorduk
wants to merge
64
commits into
NVIDIA:main
Choose a base branch
from
akifcorduk:cliques
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
594ec3f
add initial files
akifcorduk f10535f
add some comments and file name changes
akifcorduk 649062c
initial data structures
akifcorduk fe4cc7a
find all initial cliques
akifcorduk 1d46ec9
remove small cliques
akifcorduk 1474bc5
renumber cliques on addlt
akifcorduk b82f63f
clique extension is working
akifcorduk 1289cbc
Merge branch 'main' of github.com:NVIDIA/cuopt into cliques
akifcorduk 60edd8e
add extended cliques into formulation
akifcorduk 103b4c2
find constraints to remove
akifcorduk adc9c73
wip
akifcorduk 5934c12
Merge branch 'main' of github.com:NVIDIA/cuopt into cliques
akifcorduk 43f2ed0
Merge branch 'main' of github.com:NVIDIA/cuopt into cliques
akifcorduk 3001b52
habdle range constraints
akifcorduk b45c27e
fix bugs and covert to gpu problem
akifcorduk 21e565a
fix a log
akifcorduk 3ae6047
move preprocessing to presolve
akifcorduk 2c78d02
fix issues and handle ai reviews
akifcorduk 8409f17
fix bugs adj list
akifcorduk 22f778b
style checks
akifcorduk 12c8fcf
fix excluded cliques and fix extended set packing constraints
akifcorduk 5d16246
tests if threre are any complements of a variable in the extended clique
akifcorduk 6319046
fix variables if complements share a clique
akifcorduk 96385fe
add timing
akifcorduk 7cd0a4a
wip
akifcorduk 447713f
fix the knapsack indices
akifcorduk db8951a
fix weight and set packing issue
akifcorduk ab2339b
fix obj scale issue
akifcorduk 7e322eb
Merge branch 'main' of github.com:NVIDIA/cuopt into cliques
akifcorduk d7f6a80
without cliques
akifcorduk f58b8c5
with cliques
akifcorduk cb10992
add timer to cliques
akifcorduk 933beb0
add complement of the var to the adj list
akifcorduk c196ee2
adjust timer
akifcorduk 524207a
fix the bug of fixing more vars
akifcorduk bc345bb
fix issues on clique table
akifcorduk b758b9f
fix timer issues
akifcorduk 0392a62
disable jobserver flag when not actually using jobserver
aliceb-nv ee54477
disable jobserver unless explicitely requested
aliceb-nv f876fc0
better workaround fix build
aliceb-nv 1c02baa
Merge branch 'main' of github.com:NVIDIA/cuopt into fix_timer
akifcorduk 7de08d2
add timers to right_looking_lu and refactoring the basis
akifcorduk 942de9c
remove timers from cuts
akifcorduk 0b944d1
convert lambda to function and remove unnecessary checks
akifcorduk 01d68c3
Merge branch 'main' of github.com:NVIDIA/cuopt into cliques
akifcorduk ba1df82
fix merge conflicts, reduce timers
akifcorduk f395672
fix reverse_iterator
akifcorduk 71b7f2f
fix thrust changes
akifcorduk 82b2d64
handle review comments
akifcorduk d074884
add extension heuristics and fix mip gap issues
akifcorduk 0c81173
handle review comments
akifcorduk 609c578
move timer with inout parameters
akifcorduk 3d32acd
fix merge conflicts
akifcorduk 0c54ecf
fix merge conflicts
akifcorduk d01fd3b
Merge branch 'main' of github.com:NVIDIA/cuopt into cliques
akifcorduk d5791dc
handle ai reviewS
akifcorduk fc414e7
revert cmake comment
akifcorduk fff860c
Merge branch 'fix_timer' into cliques
akifcorduk 9803df2
Merge branch 'main' of github.com:NVIDIA/cuopt into cliques
akifcorduk 3acb6a9
fix adjacency checks
akifcorduk 6f6783b
fix adjacency set and var degree
akifcorduk 8bc9fb0
add copy of variable bounds
akifcorduk ba7b9ff
remove the set packing if it covers set partitioning
akifcorduk d82e592
use append row
akifcorduk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a debug bounds assert for
cstr_idx.Without a guard, an invalid
cstr_idxcan read pastrow_start. A debug assert keeps the fast path while catching misuse early.🔧 Suggested change (debug-only assert)
template <typename i_t, typename f_t> std::pair<i_t, i_t> csr_matrix_t<i_t, f_t>::get_constraint_range(i_t cstr_idx) const { + assert(cstr_idx >= 0); + assert(static_cast<size_t>(cstr_idx + 1) < this->row_start.size()); return std::make_pair(this->row_start[cstr_idx], this->row_start[cstr_idx + 1]); }🤖 Prompt for AI Agents