Add vGPU license visibility and condition management#1929
Draft
elliott-davis wants to merge 1 commit intoNVIDIA:mainfrom
Draft
Add vGPU license visibility and condition management#1929elliott-davis wants to merge 1 commit intoNVIDIA:mainfrom
elliott-davis wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
- Updated README to document new vGPU license visibility features, including annotations for license status and a condition in ClusterPolicy. - Introduced license collection logic in `license_collector.go` and corresponding tests in `license_collector_test.go`. - Implemented metrics for license status updates in `metrics_license.go` and integrated it into the NodeMetrics workflow. - Added condition management for vGPU licensing in `license_condition.go`, with tests to validate behavior in various licensing scenarios. - Enhanced permissions in `0300_clusterrole.yaml` to allow patching of node annotations. This update improves visibility and management of vGPU licensing, facilitating easier diagnostics and compliance monitoring. Closes: NVIDIA#1477 Signed-off-by: Elliott Davis <elliott@tirefire.dev>
Contributor
|
/ok-to-test 8269f86 |
Contributor
|
@elliott-davis Would you like to fix the lint issues (plus rebase) and mark this ready for review? We can take a look at it after. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
license_collector.goand corresponding tests inlicense_collector_test.go.metrics_license.goand integrated it into the NodeMetrics workflow.license_condition.go, with tests to validate behavior in various licensing scenarios.0300_clusterrole.yamlto allow patching of node annotations.This update improves visibility and management of vGPU licensing, facilitating easier diagnostics and compliance monitoring.
Note: This was generated by GPT-5.1 and is pending functional testing and review
Closes: #1477