Add extended diagnostics support to must-gather.sh using debug container for dmidecode/lspci collection#1978
Open
karthikvetrivel wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
…ner for dmidecode/lspci collection Signed-off-by: Karthik Vetrivel <kvetrivel@nvidia.com>
cdesiniotis
reviewed
Dec 15, 2025
Comment on lines
+369
to
+370
| collect_debug_diagnostic "${pod_name}" "${pod_nodename}" "dmidecode" "" "${bug_report_file}" | ||
| collect_debug_diagnostic "${pod_name}" "${pod_nodename}" "lspci" "-vvv" "${bug_report_file}" |
Contributor
There was a problem hiding this comment.
Question -- would it be possible to run nvidia-bug-report.sh itself in the debug container?
Member
Author
There was a problem hiding this comment.
Yeah, I believe so. However, it'd require adding a lot of NVIDIA utilities/libraries to the debug container. I don't think the debug contained would be "lightweight" anymore.
Do you prefer running the script from the debug container itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional extended diagnostics to
must-gather.shusing a lightweight debug container. Enables completenvidia-bug-reportcollection includingdmidecodeandlspciwithout adding these tools to the driver container (addressing CVE compliance concerns). This feature is opt-in only; when enabled, users are shown a warning about the external debug container and privileged access requirements before collection begins.Usage
Standard (existing behavior)
./must-gather.sh
Extended diagnostics
ENABLE_EXTENDED_DIAGNOSTICS=true ./must-gather.sh
Testing
Environment: K8s v1.28+, Tesla T4 GPU,
ghcr.io/nvidia/gpu-operator-debug:latestSample output verification: