Add support for NO_RUNTIME_CONFIG to disable runtime config in the nvidia-container-toolkit#2041
Open
elezar wants to merge 2 commits intoNVIDIA:mainfrom
Open
Add support for NO_RUNTIME_CONFIG to disable runtime config in the nvidia-container-toolkit#2041elezar wants to merge 2 commits intoNVIDIA:mainfrom
elezar wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
elezar
force-pushed
the
add-none-runtime
branch
from
d0a6b46 to
f608f12
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
add-none-runtime
branch
from
f608f12 to
be5904e
Compare
elezar
changed the title
elezar
requested review from
ArangoGutierrez,
cdesiniotis,
shivamerla and
tariq1890
as code owners
…he nvidia-container-toolkit Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
add-none-runtime
branch
from
be5904e to
11d1c5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a user sets NO_RUNTIME_CONFIG=true in the toolkit.Env this signals that no runtime shouls be configured for use with the NVIDIA Container Toolkit. When this is the case, we disable the injection of runtime config files and sockets.
In conjunction with NVIDIA/nvidia-container-toolkit#1521 this allows users to use the GPU Operator to install the toolkit, but to not update the runtime config.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing