Add ability to pass 'dnsConfig' and 'securityContext' attributes in the 'operator' deployment resource.#2069
Open
mihkelparna1 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
mihkelparna1
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
…he 'operator' deployment resource. Signed-off-by: Mihkel Pärna <mihkel.parna@wise.com> Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
mihkelparna1
force-pushed
the
OperatorAdditionalFields
branch
from
420116b to
62fc72b
Compare
| ports: | ||
| - name: metrics | ||
| containerPort: 8080 | ||
| {{- with .Values.operator.dnsConfig}} |
Contributor
There was a problem hiding this comment.
Can you also add these keys (with empty values) to values.yaml for discoverability?
Contributor
|
/ok-to-test 62fc72b |
| - name: metrics | ||
| containerPort: 8080 | ||
| {{- with .Values.operator.dnsConfig}} | ||
| dnsPolicy: "None" |
Contributor
There was a problem hiding this comment.
Is setting dnsPolicy: "None" overly restrictive? Afaik, you can specify dnsConfig and use a different dnsPolicy, which will merge both the settings. I think dnsPolicy should be configurable as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Tested out by rendering out all options ( Fields set, fields unset, rendering both options )