Skip to content

Fix flaking failures in the GPU Operator CI e2e tests #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JunAr7112 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

Fix flaking failures in the GPU Operator CI e2e tests #2091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tests/scripts/update-nvidiadriver.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,19 @@ test_custom_labels_override() {
exit 1
fi

# The labels override triggers a rollout of all gpu-operator operands, so we wait for the driver upgrade to transition to "upgrade-done" state.
# Wait for the operator to update the pod template with new labels
echo "Waiting for DaemonSet pod template to be updated with new labels..."
kubectl wait daemonset \
-l "app.kubernetes.io/component=nvidia-driver" \
-n "$TEST_NAMESPACE" \
--for=jsonpath='{.spec.template.metadata.labels.cloudprovider}'=aws \
--timeout=120s

# Delete driver pod to force recreation with updated labels. Existing pods are not automatically restarted due to the DaemonSet's 'OnDelete` updateStrategy.
Copy link
Contributor

@tariq1890 tariq1890 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment true? If it was, wouldn't this test fail consistently?

Copy link
Contributor Author

@JunAr7112 JunAr7112 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tariq1890 I believe test_driver_image_updates() will delete the old pod on a rerun allowing the rerun to succeed even if the test originally fails.

echo "Deleting driver pod to trigger recreation with updated labels..."
kubectl delete pod -l "app.kubernetes.io/component=nvidia-driver" -n "$TEST_NAMESPACE"

# Wait for the driver upgrade to transition to "upgrade-done" state
wait_for_driver_upgrade_done

check_nvidia_driver_pods_ready
Expand Down