Skip to content

Fix flaking failures in the GPU Operator CI e2e tests#2091

Open
JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
JunAr7112:fix_e2e_labels
Open

Fix flaking failures in the GPU Operator CI e2e tests#2091
JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
JunAr7112:fix_e2e_labels

Conversation

@JunAr7112
Copy link
Contributor

@JunAr7112 JunAr7112 commented Feb 2, 2026

Description

Fix flaking failures in the GPU Operator CI e2e tests. The issue here is that when the NVIDIADriver CR is patched with new labels, the pod template in the DaemonSet is updated with the new labels, but the existing pod isn't automatically restarted.

kubectl get daemonset -n test-operator -l "app.kubernetes.io/component=nvidia-driver" -o jsonpath='{.items[0].spec.updateStrategy}' 2>&1 | python3 -m json.tool
{
"type": "OnDelete"
}

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Verified that we no longer get the error when we delete the pod:

Checking nvidia driver pod
NAME READY STATUS RESTARTS AGE
nvidia-gpu-driver-ubuntu22.04-7bc55f95b6-ltr4c 1/1 Running 0 2m36s
Checking nvidia driver pod readiness
nvidia driver pod is ready
checking nvidia-driver-daemonset labels
SUCCESS: Pod nvidia-gpu-driver-ubuntu22.04-7bc55f95b6-ltr4c has correct labels: cloudprovider=aws, platform=kubernetes
=== test_custom_labels_override PASSED ===

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 2, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@NVIDIA NVIDIA deleted a comment from copy-pr-bot bot Feb 3, 2026
Signed-off-by: Arjun <agadiyar@nvidia.com>
@JunAr7112
Copy link
Contributor Author

/ok-to-test 7fc37a0

--for=jsonpath='{.spec.template.metadata.labels.cloudprovider}'=aws \
--timeout=120s

# Delete driver pod to force recreation with updated labels. Existing pods are not automatically restarted due to the DaemonSet's 'OnDelete` updateStrategy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment true? If it was, wouldn't this test fail consistently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tariq1890 I believe test_driver_image_updates() will delete the old pod on a rerun allowing the rerun to succeed even if the test originally fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants