Fix flaking failures in the GPU Operator CI e2e tests#2091
Open
JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix flaking failures in the GPU Operator CI e2e tests#2091JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
d6e96fd to
ccd60ef
Compare
Signed-off-by: Arjun <agadiyar@nvidia.com>
ccd60ef to
7fc37a0
Compare
Contributor
Author
|
/ok-to-test 7fc37a0 |
rajathagasthya
approved these changes
Feb 3, 2026
tariq1890
reviewed
Feb 3, 2026
| --for=jsonpath='{.spec.template.metadata.labels.cloudprovider}'=aws \ | ||
| --timeout=120s | ||
|
|
||
| # Delete driver pod to force recreation with updated labels. Existing pods are not automatically restarted due to the DaemonSet's 'OnDelete` updateStrategy. |
Contributor
There was a problem hiding this comment.
Is this comment true? If it was, wouldn't this test fail consistently?
Contributor
Author
There was a problem hiding this comment.
@tariq1890 I believe test_driver_image_updates() will delete the old pod on a rerun allowing the rerun to succeed even if the test originally fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix flaking failures in the GPU Operator CI e2e tests. The issue here is that when the NVIDIADriver CR is patched with new labels, the pod template in the DaemonSet is updated with the new labels, but the existing pod isn't automatically restarted.
kubectl get daemonset -n test-operator -l "app.kubernetes.io/component=nvidia-driver" -o jsonpath='{.items[0].spec.updateStrategy}' 2>&1 | python3 -m json.tool
{
"type": "OnDelete"
}
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Verified that we no longer get the error when we delete the pod:
Checking nvidia driver pod
NAME READY STATUS RESTARTS AGE
nvidia-gpu-driver-ubuntu22.04-7bc55f95b6-ltr4c 1/1 Running 0 2m36s
Checking nvidia driver pod readiness
nvidia driver pod is ready
checking nvidia-driver-daemonset labels
SUCCESS: Pod nvidia-gpu-driver-ubuntu22.04-7bc55f95b6-ltr4c has correct labels: cloudprovider=aws, platform=kubernetes
=== test_custom_labels_override PASSED ===