Skip to content

fix(dell): support extended HTTP boot option names#102

Draft
williampnvidia wants to merge 1 commit into
NVIDIA:mainfrom
williampnvidia:william/dell-http-boot-option-suffix
Draft

fix(dell): support extended HTTP boot option names#102
williampnvidia wants to merge 1 commit into
NVIDIA:mainfrom
williampnvidia:william/dell-http-boot-option-suffix

Conversation

@williampnvidia

Copy link
Copy Markdown

Summary

  • recognize both legacy exact Dell HTTP boot-option names and newer names with a " - "-delimited adapter/MAC/protocol suffix
  • use one bounded matcher in machine_setup_status, set_boot_order_dpu_first, and is_boot_order_setup
  • prevent false prefix matches such as Partition 1 matching Partition 10
  • add table-driven regression coverage for legacy, extended, and non-matching names

Testing

  • cargo fmt --check
  • cargo clippy --locked --all-targets --all-features --workspace -- -D warnings
  • cargo build
  • cargo test --locked -- --test-threads=1
  • focused test_dell integration test
  • focused test_dell_multi_dpu integration test

Fixes #101.

Related: #93. This is a draft fallback for the existing fix; only one implementation should be merged.

Signed-off-by: Josh P <williamp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

bug(dell): extended HTTP boot-option names cause MissingBootOption and block ingestion

1 participant