Refactor driver discovery

[elezar]

This change refactors driver discovery to prepare for the discovery of additional entities using libnvsandboxutils.

[elezar]

I don't think this was required.

[Copilot]

Pull Request Overview

This PR refactors the driver discovery workflow to centralize version detection and entity lookup in a new dgpu package and integrate libnvsandboxutils for sandbox utils discovery. Key changes include:

• Replaced bespoke CUDA and NVML version lookups with a unified getDriverVersion fallback chain.
• Introduced internal/platform-support/dgpu with option-based NewDriverDiscoverer.
• Updated all nvcdi consumers to use the new dgpu.NewDriverDiscoverer and removed old discovery helpers.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/nvcdi/wrapper.go	No functional change; remains the CDI spec wrapper.
pkg/nvcdi/management.go	Swapped CUDA version lookup for getDriverVersion and new dgpu discoverer.
pkg/nvcdi/lib.go	Refactored driver-version helpers into nvcdilib.
pkg/nvcdi/lib-nvml.go	Updated common edits to call new getDriverVersion and pass version to NVML discoverer.
pkg/nvcdi/common-nvml.go	Signature change to include version in the common NVML discoverer.
internal/platform-support/dgpu/options.go	Added new option setters (WithDriver, WithLdconfigPath, WithVersion).
internal/platform-support/dgpu/driver.go	Implemented NewDriverDiscoverer using option-driven construction.
internal/platform-support/dgpu/driver-nvsandboxutils.go	Stub for nvsandboxutils discovery.
internal/platform-support/dgpu/driver-nvml.go	Moved NVML-based driver discovery into options-based methods.
internal/nvsandboxutils/gen/.../nvsandboxutils.yml	Allowed MASK255_ constant renaming for sandbox utils.

Comments suppressed due to low confidence (4)

internal/platform-support/dgpu/options.go:89

• There is a typo in WithNvsandboxuitilsLib (should be WithNvsandboxutilsLib). Correcting this will avoid confusion and maintain consistency.

func WithNvsandboxuitilsLib(nvsandboxutilslib nvsandboxutils.Interface) Option {

internal/platform-support/dgpu/driver.go:26

• This new NewDriverDiscoverer logic is complex and currently untested—adding unit tests to cover option parsing and fallback behavior will help catch future regressions.

// NewDriverDiscoverer creates a discoverer for the libraries and binaries associated with a driver installation.

internal/platform-support/dgpu/driver.go:28

• The call to new(opts...) is invalid Go syntax and won’t initialize your options struct. Consider creating a pointer to options (e.g. o := &options{}) and then applying each opt function.

	o := new(opts...)

internal/platform-support/dgpu/driver-nvml.go:19

• The code references lookup.NewFileLocator, lookup.WithLogger, etc., but the lookup package is not imported. Add "github.com/NVIDIA/nvidia-container-toolkit/internal/lookup" (and lookup/root if needed).

import (

[Copilot]

[nitpick] Leftover TODO comments for logging failure of sub-discoverers. Consider implementing real logging or removing the TODO if not needed.

Suggested change

	// TODO: Log a warning
	o.logger.Warn(fmt.Sprintf("Failed to create nvsandboxutils driver discoverer: %v", err))

[github-actions]

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.