feat(google): send plain countryCode for address matching#6
Merged
Conversation
HashedCustomer now carries both a hashed `country` (for Meta's COUNTRY column) and a plain-text `countryPlain` (for Google's addressInfo.countryCode, which must not be hashed). This enables country to participate in Google Customer Match address matching. Country alone is not PII, so retaining the plain ISO alpha-2 value is safe. Closes #1 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1.
What
countryPlain(plain ISO alpha-2) toHashedCustomeralongside the hashedcountry.normalizer.ts#hashCustomer.addressInfo.countryCodeinsync.ts#toGoogleIdentifiers.Why
Google's
countryCodemust be plain text, but we hashcountryfor Meta parity. Keeping both lets country participate in Google address matching without regressing Meta.Tests
US.tsc --strictand build green locally.