chore(lint): add ESLint (type-aware) + Prettier and wire into CI#7
Merged
Conversation
- Flat ESLint config with typescript-eslint recommendedTypeChecked rules - Prettier for formatting; eslint-config-prettier to avoid conflicts - tsconfig.eslint.json so test/** gets type information for linting - npm scripts: lint, lint:fix, format, format:check - CI runs lint + format:check alongside typecheck/test/build - Apply Prettier formatting and fix lint findings (unnecessary casts, prefer-const, require-await, no-misused-promises in the scheduler) Closes #4 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4.
What
typescript-eslintrecommendedTypeChecked(type-aware) rules.eslint-config-prettierso the two never conflict.tsconfig.eslint.jsonsotest/**gets type info during linting (build tsconfig only includessrc/**).lint,lint:fix,format,format:check.Lint findings fixed
extractor.ts/sync.ts.prefer-constfor Google'srejectedcounter.require-await/no-misused-promises: refactored the cron scheduler to fire-and-forget an asynctick()via() => void tick().Verification (local, all green)
npm run typecheck·npm run lint·npm run format:check·npm test(24/24) ·npm run build.