feat(google): parse partial-failure details into accurate accept/reject counts#8
Merged
Merged
Conversation
…ct counts uploadToGoogle previously counted an entire batch as accepted even when Google returned a partialFailureError. Now a pure countFailedOperations() helper parses partialFailureError.details[].errors[].location.fieldPathElements to count the distinct rejected `operations` indices, and the batch's recordsAccepted/recordsRejected reflect the true split. Adds test/sync.test.ts covering chunk() and countFailedOperations() (dedup, non-operation paths ignored, batch-size cap). Closes #3 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3.
What
countFailedOperations(partialFailureError, batchSize)parses Google'sdetails[].errors[].location.fieldPathElementsto count distinct rejectedoperationsindices.uploadToGooglenow setsrecordsAccepted/recordsRejectedfrom the real split instead of counting the whole batch as accepted.GoogleAddOperationsResponsetypes with the partial-failure detail shape.Tests
test/sync.test.ts:chunk()+countFailedOperations()(dedup of repeated errors, ignores non-operation field paths, caps at batch size).