Conversation
SRWieZ
left a comment
SRWieZ
left a comment
There was a problem hiding this comment.
Yeah, I had the same problem last time I tried to upgrade the dependencies.
We might have to look into someone's fork soon.
|
It doesn't look like any forks are regularly updated. There is a PR open to update to 34, but it has been silent for a while Def preferable not to pull this package in considering the maintenance burden. I'll see if they'll accept a PR. |
|
Dammit. That package is a PITA. We may need to come up with an alternative. I don't think it's especially complex. I wouldn't fork it tho, just pull the logic straight in |
|
We can fork it but with a big warning that's it's only supposed to used in NativePHP. No support. Until there is a maintained fork upstream. |
|
Shall we merge this & create another PR for the menubar dependency & electron itself? |
|
I vote yes |
|
Cool! I need one more review to merge @NativePHP/contributors |
…tron into chore/update-dependencies
3 participants
This pull request updates several dependencies. https://github.com/NativePHP/laravel/issues/390
I wanted to upgrade Electron as well but we're locked to v33 for now since a package we're depending on hasn't been updated for a while: https://github.com/max-mapper/menubar
Updates to production dependencies:
body-parserto version^2.2.0from^1.20.3.expressto version^5.1.0from^4.21.2.Updates to development dependencies:
electron-viteto version^4.0.0from^3.0.0.viteto version^7.0.5from^6.2.1.Upgradedelectron-builderto version^26.0.19from^26.0.14.^25due to unresolved issue in26downgrade electron-builder #251
Cannot build when optional dependencies are missing electron-userland/electron-builder#9259
Furthermore it has to be noted that there are some breaking changes when we are able to upgrade electron (
33->37)https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-340
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-350
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-360
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-370
Most notably dropping support for macOS Catalina & changes in menubar behavior.