Merged
Conversation
simonhamp
reviewed
Oct 28, 2025
|
|
||
| ```php | ||
| Notification::title('Hello from NativePHP') | ||
| ->sound('file://' . resource_path('example.mp3')) |
Member
There was a problem hiding this comment.
It would be nicer if the sound method added the file:// prefix rather than forcing the developer to apply it
Author
|
@simonhamp since NativePHP/desktop#33 has now been merged, can this also be merged? |
gwleuverink
approved these changes
Dec 3, 2025
SRWieZ
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Docs to reflect the changes made in NativePHP/desktop#33