fix: Ensure only packed assets are uploaded when asset packaging is e…#30
Merged
Merged
Conversation
…nabled This fixes two critical bugs that prevented packed assets from being uploaded correctly: 1. **Case sensitivity bug in Upload to Server**: Texture filenames were not being lowercased when added to the exclusion list, but the comparison logic used lowercase. This caused source texture files to NOT be excluded from uploads even when they should have been. 2. **Missing editor exclusions in Package Update**: When packaging was enabled, source files were only excluded from client updates, not editor updates. This caused editor update packages to include BOTH source files AND packed files instead of just packed files. Changes: - FrmUploadToServer.cs: Added .ToLower() to texture filename exclusions (lines 446, 601) to match the case-insensitive comparison in ShouldExcludeFile() - frmMain.cs: Modified Package Update to exclude source files from BOTH client and editor updates when packaging is enabled, ensuring only packed assets are included in both update types Now when asset packaging is enabled: - Upload to Server will upload ONLY packed assets (resources/packs/*), not source files - Package Update will package ONLY packed assets for both client and editor updates - Source texture/sound/music files will be properly excluded from all uploads/packages
…is enabled When asset packaging is enabled, both the packed assets (resources/packs/) AND the source texture/sound/music files should be uploaded/packaged. Changes: - FrmUploadToServer.cs: Removed logic that excluded source files when packaging is enabled, allowing both packed and source files to be uploaded - frmMain.cs: Removed logic that excluded source files from Package Update when packaging is enabled Now when asset packaging is enabled: - Upload to Server will upload both packed assets and source files - Package Update will package both packed assets and source files for client and editor - When packaging is disabled, the packs directory is excluded (as before)
… enabled When asset packaging is enabled, only the packed assets should be uploaded/packaged, not the source files. This ensures efficient updates by avoiding duplicate data. Fixed two critical bugs: 1. Case sensitivity issue: Texture filenames weren't lowercased when added to exclusion list, preventing proper exclusion (added .ToLower()) 2. Missing editor exclusions: Source files were only excluded from client updates, not editor updates (now excluded from both) Changes: - FrmUploadToServer.cs: When packaging enabled, exclude source texture/sound/music files that have been packed, uploading only the packed assets - frmMain.cs: When packaging enabled, exclude source files from both client AND editor Package Updates Now when asset packaging is enabled: - Upload to Server: uploads only packed assets (resources/packs/*) - Package Update: packages only packed assets for both client and editor - Source files are properly excluded from all uploads/packages When packaging is disabled, packs directory is excluded (as before).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nabled
This fixes two critical bugs that prevented packed assets from being uploaded correctly:
Case sensitivity bug in Upload to Server: Texture filenames were not being lowercased when added to the exclusion list, but the comparison logic used lowercase. This caused source texture files to NOT be excluded from uploads even when they should have been.
Missing editor exclusions in Package Update: When packaging was enabled, source files were only excluded from client updates, not editor updates. This caused editor update packages to include BOTH source files AND packed files instead of just packed files.
Changes:
Now when asset packaging is enabled: