Skip to content

Potential fixes for 3 code quality findings #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertBlackhart merged 3 commits into from
Apr 14, 2026
Merged

Potential fixes for 3 code quality findings #41

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
812d645
Apply suggested fix to recline/repl/shell.py from Copilot Autofix
RobertBlackhart Apr 14, 2026
f001164
Apply suggested fix to recline/repl/shell.py from Copilot Autofix
RobertBlackhart Apr 14, 2026
bc403de
Apply suggested fix to recline/repl/shell.py from Copilot Autofix
RobertBlackhart Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions recline/repl/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ def relax(

_setup_repl(program_name, prompt, history_file, argv)

if single_command or not repl_mode or argv and len(argv) >= 2 and argv[1] == "-c":
has_dash_c = (argv and len(argv) >= 2 and argv[1] == "-c")
if single_command or not repl_mode or has_dash_c:
# Some external process sent us a command to run (like scp or ssh or
# so run it and exit
command = argv[2:]
Expand Down Expand Up @@ -297,12 +298,16 @@ def setup_tab_complete() -> None:
"""Set up the readline library to hook into our command completer"""

readline.set_completer_delims("")
if sys.platform == "linux":
if sys.platform.startswith("linux"):
# pyreadline3 (used for windows) doesn't implement this
# libedit (default for macos) implements this but never calls it (broken)
readline.set_completion_display_matches_hook(completer.match_command_hook)
readline.set_completer(completer.CommandCompleter(commands.COMMAND_REGISTRY).completer)
if readline.__doc__ and "libedit" in readline.__doc__:
# Heuristic backend detection: libedit is typically advertised in the module docstring.
# Keep this centralized and defensive to avoid direct fragile checks.
readline_doc = getattr(readline, "__doc__", "") or ""
is_libedit = "libedit" in readline_doc.lower()
if is_libedit:
# macos doesn't use GNU readline, but BSD libedit instead
readline.parse_and_bind("bind '\t' rl_complete")
readline.parse_and_bind("bind '^R' em-inc-search-prev")
Expand Down
Loading