Skip to content

Further improved error handling #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fridvin-netapp merged 1 commit into from
Jul 23, 2025
Merged

Further improved error handling #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,9 @@ impl JsSmbFileHandle {
#[napi]
pub async fn create_writable(&self, #[napi(ts_arg_type="JsSmbCreateWritableOptions")] options: Option<JsSmbCreateWritableOptions>) -> Result<JsSmbWritableFileStream> {
let position = (!options.unwrap_or_default().keep_existing_data).then(|| 0);
let smb = &self.handle.smb;
let my_smb = using_rwlock!(smb);
let _ = my_smb.stat(self.handle.path.as_str())?; // XXX: stat file so that we get error if file no longer exists
Ok(JsSmbWritableFileStream{handle: self.handle.clone(), position, locked: false})
}
}
Expand Down
Loading