feat(integration-tests): add ATP Storage S3 integration#367
feat(integration-tests): add ATP Storage S3 integration#367elbe0116 wants to merge 1 commit intoNetcracker:feat/atp_robot_pluginfrom
Conversation
elbe0116
changed the title
elbe0116
force-pushed
the
feat/atp_robot_plugin
branch
from
2f0b607 to
eac9cde
Compare
| {{- end }} | ||
| {{- if .Values.tests.atpStorage.username }} | ||
| - name: ATP_STORAGE_USERNAME | ||
| value: {{ .Values.tests.atpStorage.username | quote }} |
There was a problem hiding this comment.
we can't store sentive information in CR, please use secrets
elbe0116
force-pushed
the
feat/atp_robot_plugin
branch
from
eac9cde to
141aa51
Compare
| - name: ATP_REPORT_ENABLED | ||
| value: {{ .Values.tests.atpReport.enabled | quote }} | ||
| - name: ATP_STORAGE_USERNAME | ||
| valueFrom: |
There was a problem hiding this comment.
Have you tested the changes? Or all of them were just generated by the AI Agent?
There was a problem hiding this comment.
I added it a bit later after creating the PR and notion from reviewers in another repository (consul). It will be fixed and retested soon with all actual fixes
|
valueFrom is not going to work in CR. The CRD scheme should be regenerated (because of the new fields) Also, please move .Values.tests.atpStorage parameters group to a higher level, so it will be: .Values.atpStorage Such an approach with deploy parameters should be used in all services |
anikin-aa
left a comment
anikin-aa
left a comment
There was a problem hiding this comment.
Also, I don't see handling of new values in the Golang code
elbe0116
force-pushed
the
feat/atp_robot_plugin
branch
5 times, most recently
from
29700f8 to
6100509
Compare
Wire Helm values and CR fields for ATP storage, secrets, and test pod env. Document ATP parameters in README.
elbe0116
force-pushed
the
feat/atp_robot_plugin
branch
from
6100509 to
595054f
Compare
3 participants
No description provided.