refactor: centralize module testing#112
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/NethServer/ns8-kickstart/sessions/669e9cf5-11a4-4c54-8231-628f1d104c8f Co-authored-by: andre8244 <4612169+andre8244@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor module testing configuration and update test files
refactor: centralize module testing
Apr 24, 2026
Collaborator
|
@copilot rename |
Agent-Logs-Url: https://github.com/NethServer/ns8-kickstart/sessions/2d6d15ed-501a-4b17-a311-ac98b3109e17 Co-authored-by: andre8244 <4612169+andre8244@users.noreply.github.com>
Contributor
Author
andre8244
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates test infrastructure to the centralized NS8 testing framework (
ns8-github-actions), replacing the bespoketest-module.shapproach.Changes
.github/workflows/test-module.yml— Replaced multi-job workflow with a single delegating job usingNethServer/ns8-github-actions/.github/workflows/test-module.yml@v1; addsui_tests_strategy: on_renovate_ui_changetests/kickstart.robot→tests/10__kickstart.robot— Renamed for ordering;Set Suite Variable→Set Global Variableso${module_id}is visible across test suitestests/20__ui.robot— New Robot Framework UI test using theBrowserlibrary; captures screenshots of Status and Settings pages via cluster-admin.gitignore— Addedtests/outputs/README.md— Replaced local "Testing" section with a pointer to the ns8-github-actions running tests locally guidetest-module.sh— DeletedRef: NethServer/dev#7281
Original prompt
refactor: centralize module testing
Ref:
Changes to perform
1. Replace
.github/workflows/test-module.ymlReplace the entire content of
.github/workflows/test-module.ymlwith:2. Update robot test files (because
ui/src/App.vueexists)2a. Rename
tests/kickstart.robot→tests/10__kickstart.robotThe current
tests/kickstart.robotdoes not start with a number, so rename it totests/10__kickstart.robot.In this file, change
Set Suite VariabletoSet Global Variable. The variable name stays${module_id}.The new content of
tests/10__kickstart.robotshould be:Also delete the old
tests/kickstart.robotfile.2b. Create
tests/15__ui.robotSince the install test is
10__kickstart.robotand there are no other numbered test files, name the UI test15__ui.robot(using double underscores, consistent with10__kickstart.robot).The variable for the module ID in the install file is
${module_id}, so use${module_id}instead of${MID}everywhere.Content of
tests/15__ui.robot:3. Update
.gitignoreAdd
tests/outputs/to.gitignore(the root-level one). Append it at the end of the file.Current
.gitignoreends at line 104 (.tern-port). Add:4. Update
README.md— replace the "Testing" sectionThe current README.md has a "Testing" section (lines 89–97):
Replace it with this short section (from ns8-mail README lines 299-301). Use the title "Running tests locally" (matching what the ns8-mail README uses for the section) but keep
## Testingas the heading style if the original had## Testing. Actually, looking at ns8-mail's README, the section heading is## Running tests locally. Use that exact heading and content: