Releases: NetoECommerce/Skeletal
23.1.0
20.1.0
All Changes
- ℹ️ - updated preorder logic - philcon93
- ℹ️ - Implement specific_autohide
- ℹ️ - npm audit fix - philcon93
- ℹ️ - updated preorder logic to include WEBSTORE_USE_PREORDER_QUANTITY - philcon93
- ℹ️ - CAT-1007 updated invoice_body payment methods to be more robust - philcon93
- ℹ️ - Merge pull request #491 from NetoECommerce/topic/july_dependency_update - npm audit fix - philcon93
- ℹ️ - CAT-1007 added escape tags around payment method name on invoice - philcon93
- ℹ️ - Merge pull request #492 from NetoECommerce/feature/CAT-1007_invoice_page - CAT-1007 updated invoice_body payment methods to be more robust - philcon93
- ℹ️ - CAT-967 make sure the invoice page will show webpayment method was used - jeff-stamborski
- ℹ️ - Added Meta for noindex, nofollow - kiel-abraham
- ℹ️ - Merge pull request #493 from NetoECommerce/topic/CAT-967_add_webpayments_param_to_invoice_page - CAT-967 make sure the invoice page will show webpayment method was used - philcon93
- ℹ️ - Removed disp_ajax_templ event listener - philcon93
- ℹ️ - Merge pull request #494 from NetoECommerce/kiel/meta-noindex - Added Meta for noindex, nofollow - philcon93
- ℹ️ - Merge pull request #464 from NetoECommerce/feature/specific_autohide - Implement specific_autohide - philcon93
- ℹ️ - removed submit_token references - philcon93
- ℹ️ - Added IE compatibility mode meta tag - philcon93
- ℹ️ - updated links and scripts to not include type - philcon93
- ℹ️ - updated styles to not include type - philcon93
- ℹ️ - Merge pull request #496 from NetoECommerce/topic/remove_disp_ajax_templ - Removed disp_ajax_templ event listener - philcon93
- ℹ️ - Merge pull request #497 from NetoECommerce/topic/remove_submit_token - removed submit_token references - philcon93
- ℹ️ - Merge pull request #498 from NetoECommerce/topic/ie_compatibility_mode - IE compatibility mode meta tag - philcon93
- ℹ️ - Merge pull request #499 from NetoECommerce/topic/css_js_includes - css/style/js includes - philcon93
- ℹ️ - scoped all custom.js to nCustom instead of jQuery extend - philcon93
- ℹ️ - changed tooltip initialise to be in doc ready and bootstrap suggest data attribute - philcon93
- ℹ️ - Added nofollow to platform branding link -
Will have a positive SEO impact. - brandonsheppard - ℹ️ - Update checkout.template.html - brandonsheppard
- ℹ️ - CAT-1091 fixed extra option breaking layout - philcon93
- ℹ️ - Merge pull request #502 from NetoECommerce/platform-branding-nofollow - Added nofollow to platform branding link. - philcon93
- ℹ️ - Merge pull request #503 from NetoECommerce/feature/CAT-1091-extra_options - CAT-1091 fixed extra option breaking layout - philcon93
- ℹ️ - Merge pull request #501 from NetoECommerce/topic/custom_js_clean_up - Topic/custom js clean up - philcon93
- ℹ️ - Merge pull request #505 from NetoECommerce/stockist-api-key-logic - Stockist API key logic - philcon93
- ℹ️ - added node_sass for development - philcon93
- ℹ️ - added components preorder logic from v3 branch - philcon93
- ℹ️ - Merge pull request #507 from NetoECommerce/topic/node_sass - node_sass for development - philcon93
- ℹ️ - fix delete wishlist - neto-ben
- ℹ️ - page wishlist - neto-ben
- ℹ️ - forgot closing in wishlist list - neto-ben
- ℹ️ - T404-1346 use the config instead of hard-coding an arbitrary number - neto-ben
- ℹ️ - T404-1346 fix delete wishlist in the customer section - neto-ben
- ℹ️ - Merge pull request #508 from NetoECommerce/topic/wishlist - Paging wishlist items and fix delete wishlist - philcon93
- ℹ️ - Merge pull request #419 from NetoECommerce/pre-order-stock-investigation - Preorder logic - philcon93
19.7.0
All Changes
- ℹ️ - Use jQuery .get() in place of XMLHttpRequest() - matt-downs
- ℹ️ - added plumber for better error handling - philcon93
- ℹ️ - started using paypal_express_js tag over logic in template - philcon93
- ℹ️ - updated bootstrap to 4.3.1 - philcon93
- ℹ️ - fontawesome css to 5.7.2 and vendor js to 4.3.0 - philcon93
- ℹ️ - split bootstrap include outside of variables partial - philcon93
- ℹ️ - updated vendor permissions - philcon93
- ℹ️ - refactored edit_account page so its more readable, modern and doesn't pollute the global space - philcon93
- ℹ️ - refactored edit_address javascript to be more modern - philcon93
- ℹ️ - removed unused js in edit_address - philcon93
- ℹ️ - fixed breadcrumb - philcon93
- ℹ️ - updated gulp-postcss 8.0.0, ntheme 1.9.0 and simple-github-release to use https - philcon93
- ℹ️ - Update no shipping methods logic to check for ship_zip instead of ship_country - matt-downs
- ℹ️ - Remove executable permissions from source files - matt-downs
- ℹ️ - updated theme editor button styles to be more aligned with bootstrap styles - philcon93
- ℹ️ - Add nofollow to filter links - matt-downs
- ℹ️ - Duplicate Class - Found a duplicate class in this template - GerryFort
- ℹ️ - updated cart to have responsive classes - philcon93
- ℹ️ - added margin bottom to checkout now button - philcon93
- ℹ️ - removed cssnext in favour for autoprefixer and cssnano - philcon93
- ℹ️ - CAT-695 updated static-assets to reference cdn.neto instead of local - philcon93
- ℹ️ - CAT-695 updated cdn.neto to use correct path assets.netostatic - philcon93
- ℹ️ - changed show_platform_branding a tag to just be the neto word - philcon93
- ℹ️ - UX-268 updated dependencies not to be outdated - philcon93
- ℹ️ - 4.4.0 - philcon93
- ℹ️ - UX-268 updated vendor.js to use 4.4.0 - philcon93
- ℹ️ - UX-268 added gulp-chmod as css files didn't have correct permissions - philcon93
19.2.0
Welcome 2019!
We have added some great changes since the last release. From updating the google verification meta tag #462, adding in more structured data #465, refactoring the invoice templates #457, to updating our core front end dependencies #459.
Happy New Year 🐉 🎆
All Changes
- ℹ️ - Add condition microdata - kiel-abraham
- ℹ️ - updated jquery to version 3.3.1 - philcon93
- ℹ️ - Add 24 hour ttl to cache tags - matt-downs
- ℹ️ - Added additional cache functions around some menu functions - matt-downs
- ℹ️ - Revert long ttl on product cache functions - matt-downs
- ℹ️ - updated custom.js to use update jQuery syntax - philcon93
- ℹ️ - updated jquery syntax on templates - philcon93
- ℹ️ - fixed up product scripts js - philcon93
- ℹ️ - updated jquery ui to 1.12.1 - philcon93
- ℹ️ - updated zoom and countdown plugins - philcon93
- ℹ️ - updated product page lightbox script and vendor script - philcon93
- ℹ️ - made checkValidQty use $.nPopupBox instead of fancybox - philcon93
- ℹ️ - removed references of fancy box in favour of $.nPopupBox - philcon93
- ℹ️ - Adding content level for nested content/content with a parent content page
- ℹ️ - made the 3 invoice template use an include template for DRY code - philcon93
- ℹ️ - added details param to show_order functions - philcon93
- ℹ️ - Refactor invoice template - philcon93
- ℹ️ - CAT-336 Invoice page show_order performance improvements - philcon93
- ℹ️ - merged in master - philcon93
- ℹ️ - updated lock to include jquery3 - philcon93
- ℹ️ - fixed up voucher submit trigger - philcon93
- ℹ️ - updated vendor permissions - philcon93
- ℹ️ - Adding content level for nested content/content with a parent page - philcon93
- ℹ️ - Merge pull request #453 from NetoECommerce/feature/cache - philcon93
- ℹ️ - updated configs for performance benefits - philcon93
- ℹ️ - updated og type to be conditional - philcon93
- ℹ️ - fixed up google verication into meta tag - philcon93
- ℹ️ - Merge pull request #451 from NetoECommerce/kiel-abraham-NewCondition
- philcon93
- ℹ️ - Convert spaces to tabs for consistancy with other templates - matt-downs
- ℹ️ - Added 'position' schema data to Breadcrumb function on all CMS templates - bloycey
- ℹ️ - OG:type to be conditional - philcon93
- ℹ️ - updated package dependencies - philcon93
- ℹ️ - updated package dependencies - philcon93
- ℹ️ - Merge pull request #463 from NetoECommerce/feature/cleanup - philcon93
- ℹ️ - Added 'position' schema data to Breadcrumb function on all CMS templates - philcon93
- ℹ️ - replaced meta tag with GOOGLE_VERIFICATION - philcon93
- ℹ️ - updated configs based on Jeffs findings - philcon93
- ℹ️ - merged in master - philcon93
- ℹ️ - merged in master - philcon93
- ℹ️ - Configs performance update - philcon93
- ℹ️ - added btn-link to theme editor styles - philcon93
- ℹ️ - btn-link to theme editor styles - philcon93
- ℹ️ - Google verification into meta tag - philcon93
- ℹ️ - Merge branch 'master' into feature/jquery3 - philcon93
- ℹ️ - updated wholesaleregister form to only show abn for AU users - philcon93
- ℹ️ - updated edit account pages for i18n - philcon93
- ℹ️ - updated suburb labels to include city - philcon93
- [:information_source:](https://github.com/NetoECommerce/Skeletal...
18.11.0
Yo team,
It's been awhile, October was a slow month for Skeletal so we held off a release until November so it had some meaningful changes. One major item that came from this release is the addition of a shipping calcualtor config! Now merchants will be able to change which type of shipping calculator they wish to display on their webstore with a change of advance config. More information on these changes can be found in it's PR:
✌️
All Changes
- ℹ️ - Starting the ground work—everything works except for the cart page calculators - brandonsheppard
- ℹ️ - Merge branch 'master' into shipping-calculator-config - brandonsheppard
- ℹ️ - Fixing the cart page calculator. - brandonsheppard
- ℹ️ - Show SEO page heading if set (#412)
- ℹ️ - added test id to footer business details - philcon93
- ℹ️ - Merge pull request #442 from NetoECommerce/hotfix/CAT-238_business_details - philcon93
- ℹ️ - Make the required review fields actually required - matt-downs
- ℹ️ - popup carousel arrows display on mobile - craigblunden
- ℹ️ - popup carousel arrows display on mobile - craigblunden
- ℹ️ - iOS Select Option Overflow - GerryFort
- ℹ️ - Merge pull request #443 from NetoECommerce/matt-downs-patch-1 Make the required review fields actually required - philcon93
- ℹ️ - Merge pull request #445 from NetoECommerce/hotfix/mobile-carousel-arrows - philcon93
- ℹ️ - Update readme (#446) - matt-downs
- ℹ️ - updated product image alt tags - philcon93
- ℹ️ - updated to master - philcon93
- ℹ️ - made shipping calc code more dry - philcon93
- ℹ️ - refined shipping calc types - philcon93
- ℹ️ - fixed up shipping inputs - philcon93
- ℹ️ - fixed caret vertical alignment - philcon93
- ℹ️ - updated to gulp4 - philcon93
- ℹ️ - updated ntheme version - philcon93
- ℹ️ - show third level menu items for mobile - philcon93
- ℹ️ - use main bootstrap import instead of partials - philcon93
- ℹ️ - Merge pull request #450 from NetoECommerce/hotfix/b4_child_themes_fixes - philcon93
- ℹ️ - updated to use new shipping calculator type config - philcon93
- ℹ️ - fixed majority of package security issues - philcon93
- ℹ️ - Fix shipping_methods function so that it actually reads from the ship_city and ship_state - matt-downs
- ℹ️ - removed app.css so build/compile scripts take care of creating file - philcon93
- ℹ️ - Merge pull request #448 from NetoECommerce/feature/UX-51_alt_imgs - philcon93
- ℹ️ - Merge pull request #452 from NetoECommerce/hotfix/npm_audit - philcon93
- ℹ️ - updated readme - philcon93
- ℹ️ - typo - jakesergeant
- ℹ️ - Merge pull request #454 from NetoECommerce/hotfix/remove_app_css - philcon93
- ℹ️ - Merge pull request #447 from GerryFort/patch-5 iOS Select Option Overflow - philcon93
- ℹ️ - fixed shipping calc inconsistency - philcon93
- ℹ️ - added country_search option for shipping calc - philcon93
- ℹ️ - fixed shipping calc error for child products - philcon93
- ℹ️ - moved hasShippingCalc to product_scripts - philcon93
- ℹ️ - updated shipping calc country id's - philcon93
- ℹ️ - Merge pull request #449 from NetoECommerce/shipping-calculator-config - philcon93
18.9.0
All Changes
- ℹ️ - Removes data tag, and pulls reviews from parent product. - mmwoods
- ℹ️ - Merge branch 'master' of github.com:NetoECommerce/Skeletal into review-stars - matt-downs
- ℹ️ - Pull reviews in product header from parent if SHOW_CHILD_PRODUCT_REVIEWS config is true - matt-downs
- ℹ️ - Pull review logic to separate template - matt-downs
- ℹ️ - remove buildkite workflow - philcon93
- ℹ️ - updated readme - philcon93
- ℹ️ - Updated font awesome to v5.2.0 - bloycey
- ℹ️ - product page accordion tab - jakesergeant
- ℹ️ - Merge pull request #432 from NetoECommerce/hotfix/remove_buildkite_workflow - UX-80 - Remove buildkite - philcon93
- ℹ️ - Made "filter products" heading a block element - bloycey
- ℹ️ - Updated font awesome to v5.2.0 - philcon93
- ℹ️ - Made "filter products" heading a block element - philcon93
- ℹ️ - indentation fix - jakesergeant
- ℹ️ - indentation fix - jakesergeant
- ℹ️ - indentation fix - jakesergeant
- ℹ️ - indentation fix - philcon93
- ℹ️ - merged in master - philcon93
- ℹ️ - reference reviews template in header template - philcon93
- ℹ️ - fixed up logic and star style - philcon93
- ℹ️ - Merge branch 'master' into feature/product-page-accordion-tabs - philcon93
- ℹ️ - sass up tabbable - philcon93
- ℹ️ - reverted package-lock - philcon93
- ℹ️ - removed excess css - philcon93
- ℹ️ - removed config for review stars logic - philcon93
- ℹ️ - Display parent review stars product page - philcon93
- ℹ️ - Product page accordion tabs - philcon93
- ℹ️ - Added missing position schema data - jakesergeant
- ℹ️ - moved itemscope and itemtype attributes - jakesergeant
- ℹ️ - Accordion links should be block elements for ease of use. - bloycey
- ℹ️ - Added missing position schema data - philcon93
- ℹ️ - Accordion links on product page are now block elements - philcon93
- ℹ️ - Update paypal image location - jeff-stamborski
- ℹ️ - Remove reference to neto_checkout css file - jeff-stamborski
- ℹ️ - Update template dir css links to ntheme_asset - jeff-stamborski
- ℹ️ - Topic/remove references to neto checkout assets - philcon93
18.8.0
A couple of bug fixes since the major framework update, and a handful of features and performance additions. Overall, it was a good month 👌
All Changes
- ℹ️ - HTML tags showing in customer comments
- ℹ️ - One too many div when 5+ vouchers are ordered
- ℹ️ - replaced payment_methods with checkout_pay_icons - philcon93
- ℹ️ - updated less to include neto naming conventions - philcon93
- ℹ️ - merged #418 in - philcon93
- ℹ️ - made zip logo same size as others so less inline styles - philcon93
- ℹ️ - concat jquery popper and bootstrap - philcon93
- ℹ️ - Update build scripts to allow gulp as a local dependency - matt-downs
- ℹ️ - Update readme to describe updated compile commands - matt-downs
- ℹ️ - updated branch to master - philcon93
- ℹ️ - fixed up vouchers template - philcon93
- ℹ️ - Add margin to bottom of payment plans card - matt-downs
- ℹ️ - Remove duplicate home button - matt-downs
- ℹ️ - merged in master - philcon93
- ℹ️ - add vendor script to CDN - philcon93
- ℹ️ - Merge pull request #423 from NetoECommerce/hotfix/cart-plan-margin - Add margin to bottom of payment plans card on cart page - philcon93
- ℹ️ - Merge pull request #421 from NetoECommerce/feature/local-gulp - Update build scripts to allow gulp as a local dependency - philcon93
- ℹ️ - new paypal link implementation - philcon93
- ℹ️ - Update custom.js
- ℹ️ - Merge pull request #425 from NetoECommerce/feature/CAT-185_paypal_link - New Paypal link implementation - philcon93
- ℹ️ - Merge pull request #424 from NetoECommerce/hotfix/duplicate-home-button - Remove duplicate home button on content review success page - philcon93
- ℹ️ - Merge pull request #426 from NetoECommerce/wishlist-image-change - Custom.js addToWishList params - philcon93
- ℹ️ - Merge pull request #356 from NetoECommerce/payment_methods_icons_update - CAT-81 - replace payment_methods with checkout_pay_icons - philcon93
- ℹ️ - Merge pull request #420 from NetoECommerce/feature/vendor_scripts - Concat jquery, popper and bootstrap - philcon93
- ℹ️ - added test id to invoice page - philcon93
- ℹ️ - Merge pull request #428 from NetoECommerce/hotfix/behat_additions - Added test id to invoice page - philcon93
- ℹ️ - updated permissions - philcon93
- ℹ️ - Merge pull request #429 from NetoECommerce/hotfix/permissions - Updated permissions - philcon93
- ℹ️ - Change remove_single_url tag back to remove_url - matt-downs
- ℹ️ - Merge pull request #431 from NetoECommerce/hotfix/remove_url - Fix issue where category and instock filters could not be toggled off once selected - philcon93
- ℹ️ - Merge pull request #422 from NetoECommerce/hotfix/html_showing - Voucher template fix - philcon93
18.7.0
Bootstrap update
Updated CSS framework from Bootstrap 3.3.6 to 4.1.
Almost every file in the Skeletal repo has been updated in some way to accommodate for this update. There are huge benefits to updating our CSS framework: better modern browser support; using modern CSS (e.g Flexbox); simplified components with extensive utility classes; etc. It's just a great move forward. Bootstrap has created a migration article about what is new: https://getbootstrap.com/docs/4.0/migration/#summary
Some important changes:
- Grid system - https://getbootstrap.com/docs/4.1/layout/grid/
- Flexbox - https://getbootstrap.com/docs/4.1/utilities/flex/
- Extensive utility classes - https://getbootstrap.com/docs/4.1/utilities/spacing/
Font Awesome 5
Updated our icon library from Font Awesome 4 to 5!
Each icon needs to have the name and the proper prefix specified. Version 4 just had one prefix — fa. Version 5 has four prefixes: https://fontawesome.com/how-to-use/upgrading-from-4#icon-name-changes
Mobile header
The mobile header has been redesigned to be more slimline, and because of the power of Bootstrap 4, the dropdown menu works by default on mobile!
Invoice/confirmation templates
New invoice/confirmation page design! This has been designed based on tons of usability research, communicating directly with Neto merchants and multiple design sessions with key people from all different departments of Neto.
SASS
Bootstrap 4 uses SASS instead of LESS, so we also updated our themes to use SASS. We also placed the SASS files directly under src, e.g 'src/scss', instead of being inside of css, e.g 'src/css/less'. This was to help keep the preprocessor files separate to the compiled output.
SASS and LESS are very similar; for the most part the syntax is only a little different, e.g to do variables in LESS you would have the following:
@primary-color: #333;
body {
color: @primary-color;
}
And in SASS:
$primary-color: #333;
body {
color: $primary-color;
}
Easy right!
Mixins are similar, LESS has '.custom-mixin', while SASS mixins starting with '@mixin' and being called with '@include'.
Import are exactly the same, we have just updated one of the partials names because of SASS overrides;
// Bootstrap and overides
@import "./_bootstrap";
// Neto standard styles
@import "./_neto";
// Custom styles
@import "./_custom";
More info on SASS overrides can be found in the Bootstrap documentation: https://getbootstrap.com/docs/4.1/getting-started/theming/#variable-defaults
For more in-depth documentation on SASS: https://sass-lang.com/
Gulp task
Our gulp build process has been updated to use SASS and also optionally use the JS from the theme dependency. I.e. Bootstrap and Popper.js are included via package.json and the gulp task 'gulp js' will bring those relevant JS files into the theme. This allows the theme to directly link with its dependency. Also, when Bootstrap gets updated for new features or bug fixes, a theme could update its dependencies and use that version of Bootstrap. By default Skeletal will use CDN versions of these JS files for performance, but we will be actively keeping our dependencies up to date as well.
[%cdn_asset html:'1' type:'js' library:'popper' version:'1.14.3'%]popper.min.js[%/cdn_asset%]
[%cdn_asset html:'1' type:'js' library:'bootstrap' version:'4.1.1'%]bootstrap.min.js[%/cdn_asset%]
As Bootstrap is using SASS, we updated the gulp tasks to use gulp-sass instead of gulp-less, and we have added a basic setup to use PostCSS and PostCSS-cssnext as well. PostCSS-cssnext is a PostCSS plugin that helps you to use the latest CSS syntax today, and with the basic setup vendor prefixes are automatically added.
var path = require('path');
var fs = require('fs');
var gulp = require('gulp');
var postcss = require('gulp-postcss');
var cssnext = require('postcss-cssnext');
var sass = require('gulp-sass');
var config = {};
config.src = './src';
config.JS = config.src + '/js';
config.SCSS = config.src + '/scss';
config.CSS = config.src + '/css';
// Compile SASS into CSS
gulp.task('sass', function() {
var plugins = [ cssnext ];
return gulp.src(config.SCSS +'/*.scss')
.pipe(sass())
.pipe(postcss(plugins))
.pipe(gulp.dest(config.CSS))
});
We hope theme developers will be able to leverage this and configure it to their theme's needs.
JS
We have updated the custom functions inside of custom.js to be scoped to one main object, 'nCustom'. This has been done to reducing bloating the global space but also to make our code dryer, to reduce repetition elsewhere in the theme.
Previously we used a click event listener on '.btn-load' to change its state with an anonymous function:
$(".btn-loads").click(function(){
$(this).button("loading");
var pendingbutton=this;
setTimeout(function(){
$(pendingbutton).button("reset");
},3000);
});
This mostly worked, but didn't take into account product page reloads with AJAX, so we needed a better way to work with event delegation. Also Bootstrap no longer supports the .button('loading') method, so we needed a new way to handle the actual function. Now, we create our scoped function and then use that function with two different event listeners based on whether it is an AJAX section:
//
//custom.js
//
var nCustom = {
funcs : {
buttonLoading: function(){
...
}
}
}
$(document).on("click", ".btn-loads", nCustom.funcs.buttonLoading);
//
// products/includes/products_scripts.template.html
//
$(document).on("click", ".btn-ajax-loads", nCustom.funcs.buttonLoading);
B@SE
All b@se has also been updated to use modern syntax, e.g removal of comment tags around b@se functions and use of data/config tags instead of data/config functions.
Old code for filtering by price:
[%PARAM *body%]
[%DATA id:'selected' if:'==' value:'1'%]
[%PARAM *if_true%]...[%/PARAM%]
[%PARAM *if_false%]
[%DATA id:'min' if:'=' value:'0'%]
[%DATA id:'max' if:'>' value:'0'%]...[%/DATA%]
[%/DATA%]
[%DATA id:'min' if:'>' value:'0'%]
[%DATA id:'max' if:'>' value:'0'%]...[%/DATA%]
[%/DATA%]
[%DATA id:'max' if:'=' value:'0'%]...[%/DATA%]
[%/PARAM%]
[%/DATA%]
[%/PARAM%]
New code:
[%param *body%]
[%if [@selected@]%]
...
[%else%]
[%if [@min@] == 0 AND [@max@] > 0%]
...
[%elseif [@min@] > 0 AND [@max@] > 0%]
...
[%elseif [@max@] == 0%]
...
[%/if%]
[%/if%]
[%/param%]
Node dependencies
Skeletal's dependencies have been updated, mostly to accommodate for Bootstrap 4 using SASS, but it also includes 'ntheme' and 'simple-github-release'.
simple-github-release
We have changed our releasing type from semver to a much simpler version based on chronological versioning. This was because semver didn't make sense with Skeletal, while chronological versioning makes clear the next version number, build date, and keeps it simple. The release process uses a module Brandon developed which is open-source and can be viewed here: https://github.com/brandonsheppard/simple-github-release
ntheme
ntheme lets you generate and compile a Neto theme. This is a direct dependency for Skeletal because it is needed for compiling to the theme store. When child themes are created, it has all the dependencies needed to compile correctly for theme store. This will replace the 'bin/compile' command with 'npm run compile'. This was done so the compile script wasn't a file in Skeletal (like it currently is) but a dependency, leveraging the ability to update the script for new features or fix bugs more easily. More on how this is used for child themes in a moment
Child themes
Child themes can depend off Skeletal, like they would for any node module:
"devDependencies": {
"Skeletal": "git://github.com/NetoECommerce/Skeletal.git"
},
This is extremely useful as _neto.scss contains all styles that are needed for a theme to work correctly, be that npopup, search results, cart dropdown, payment icons etc. Essentially, components that are the same across themes.
Instead of a theme including these styles in their own scss partial, theme developers could update their app.css to the following:
// Bootstrap and overides
@import "./_bootstrap";
// Neto standard styles
@import "../../../node_modules/Skeletal/src/scss/_neto";
// Custom styles
@import "./_custom";
If there are any updates to Neto base styles, the repository can update its dependency, and on gulp task 'gulp sass', it will have the new Neto styles. If a theme styles need to be adjusted, they can be overwritten as standard CSS in the _custom.scss partial. This makes it much easy to maintain themes and shows what actual styles are different to the child theme.
When generating a new theme, it will use the new themes _neto.scss by default. This is to give the option for theme developers to customise if desired. This would require the developer to do more maintenance/update work but we want the developer to decide if they want to directly edit this CSS or to override in their _custom.scss partial.
Theme-starter-kit
The theme starter kit has been redeveloped as a node module: https://www.npmjs.com/package/ntheme
Generating a theme
Simply run the following command:
ntheme generate themeName
Option
-b 'branch'
Instead of generating your theme off the Master branch of Skeletal, you can target a branch or release tag...
18.5.1
This release had a focus on updating Skeletal for GDPR. All theme developers will need to take these changes into account when developing and maintaining their themes. You can view the specific PR's here:
This was just a small release in order to have a clear cut off for the next release. Get excited, its going to be a big one :)
All Changes
- ℹ️ - Add class btn-ajax-loads to trigger data-loading-text on product page buttons - matt-downs
- ℹ️ - Fix issue where button onclick loading animation would fail after switching variations - matt-downs
- ℹ️ - Pull duplicated code into reusable function - matt-downs
- ℹ️ - Show loading animation on add to cart button when changing kit component variation - matt-downs
- ℹ️ - Fix issue 397 - matt-downs
- ℹ️ - Removed meta image tag - matt-downs
- ℹ️ - Add surcharge row to cart pricing information - matt-downs
- ℹ️ - Fix spacing between GST Inc. - matt-downs
- ℹ️ - Removed meta image tag - philcon93
- ℹ️ - Added newsletter unsubscribe to edit account page - matt-downs
- ℹ️ - Min on shipping calculator - kiel-abraham
- ℹ️ - Min on shipping calculator - philcon93
- ℹ️ - moved opt_in JS with other JS on template - philcon93
- ℹ️ - changed ID to follow ID standards - philcon93
- ℹ️ - Added newsletter unsubscribe to edit account page - philcon93
- ℹ️ - changed event listner to correctly handle for different ajax templates - philcon93
- ℹ️ - Notify Me button does not show loading animation on variation switch - philcon93
- ℹ️ - Merge branch 'master' into feature/matt-kit-variation-load - philcon93
- ℹ️ - standardised loading state - philcon93
- ℹ️ - fixed pre-order disabled colour - philcon93
- ℹ️ - Show loading for kit component variation - philcon93
- ℹ️ - Add surcharge row to cart pricing information - philcon93
- ℹ️ - changed newsletter input on register form to opt-in - philcon93
- ℹ️ - Broken functionality on email address contains '+' character - philcon93
- ℹ️ - added in privacy policy on login template - philcon93
- ℹ️ - udpated wholesale form for gdpr - philcon93
- ℹ️ - updated footer for gdpr - philcon93
- ℹ️ - updated notify me for gdpr - philcon93
- ℹ️ - spelling privacy - philcon93
- ℹ️ - fixed spacing logic - philcon93
- ℹ️ - changed the value for subscribe input - philcon93
- ℹ️ - GDPR update - philcon93
18.5.0
Yo, goat here! More amazing work has gone into Skeletal this past month, with a lot of great bug fixes and some template enhancements. We have also been working hard on preparations for the next big major release of Skeletal! More information will be coming soon, but if you would like a hint, check out the following PR ;)
🤙
All Changes
- ℹ️ - Display Out of Stock for relevant SKUs by default - craigblunden
- ℹ️ - Updating 'category:' to 'filter_category:' - mmwoods
- ℹ️ - Removed unused scripts from product review templates - matt-downs
- ℹ️ - Fixed issue where custmoername field would not be submitted if review was posted by logged in user - matt-downs
- ℹ️ - Adjusted style/size of buttons and added fa icons to match the rest of the system - matt-downs
- ℹ️ - Added required attribute to required login and register fields - matt-downs
- ℹ️ - Removed some redundant value tags from login and register forms - matt-downs
- ℹ️ - Decrease z-index on cart - matt-downs
- ℹ️ - Added shipping not available to cart page - matt-downs
- ℹ️ - Removed green background from shopping cart total row, added green text colour to total and increased size. - matt-downs
- ℹ️ - Merge branch 'master' of https://github.com/NetoECommerce/Skeletal into hotfix/272 - matt-downs
- ℹ️ - Merge branch 'master' of https://github.com/NetoECommerce/Skeletal into matt-login-register-required - matt-downs
- ℹ️ - reg_username should be type=hidden, not hidden by class - matt-downs
- ℹ️ - Merge branch 'master' of https://github.com/NetoECommerce/Skeletal into feature/matt-issue-347 - matt-downs
- ℹ️ - Update styling of shipping not available message on cart - matt-downs
- ℹ️ - Update shipping not available message on product page - matt-downs
- ℹ️ - Heading should be h3 - matt-downs
- ℹ️ - Fixed indentation - matt-downs
- ℹ️ - Change Neto website link from neto.com.au to netohq.com. Helps build backlinks to our new domain - seanockert
- ℹ️ - Revert to 'e-commerce' for consistency - seanockert
- ℹ️ - Merge pull request #380 from NetoECommerce/hotfix/footer-neto-link. Change Neto website link to netohq.com - philcon93
- ℹ️ - Fixed double class attribute - jakesergeant
- ℹ️ - Fixed double class attribute - jakesergeant
- ℹ️ - Fixed double class attribute - jakesergeant
- ℹ️ - Merge pull request #382 from NetoECommerce/hotfix/html-error. Fixed double class attribute - matt-downs
- ℹ️ - Merge pull request #320 from NetoECommerce/random-products. Updating 'category:' to 'filter_category:' - philcon93
- ℹ️ - Merge pull request #322 from matt-downs/matt-review-forms. Review forms changes - philcon93
- ℹ️ - Merge pull request #332 from matt-downs/matt-login-register-required. Added required attribute to required login/register fields - philcon93
- ℹ️ - fixed css to use correct classes - philcon93
- ℹ️ - Merge pull request #379 from NetoECommerce/hotfix/matt-approve-quote-button. Approve quote button wants to be noticed - philcon93
- ℹ️ - Merge pull request #384 from NetoECommerce/hotfix/339_alerts. Fixed css to use correct classes - matt-downs
- ℹ️ - PCI-549 remove all references to masterpass - neto-ben
- ℹ️ - Merge pull request #349 from matt-downs/feature/matt-issue-347. Added "shipping not available" alert to cart page - matt-downs
- ℹ️ - Merge pull request #385 from neto-ben/PCI-549_remove_references_to_masterpass. PCI-549 remove all references to masterpass - philcon93
- ℹ️ - Update to variation_qty tag - matt-downs
- ℹ️ - Merge branch 'master' of github.com:NetoECommerce/Skeletal into craigblunden-patch-4
- ℹ️ - Merge branch 'master' of github.com:NetoECommerce/Skeletal into hotfix/272 - matt-downs
- ℹ️ - Update header cart to use @zindex-navbar-fixed variable for zindex - matt-downs
- ℹ️ - Removed '>' on line 11. Unncessary '>' on line 11 after 'class="btn btn-default"' - GerryFort
- ℹ️ - Merge pull request #293 from NetoECommerce/craigblunden-patch-4. Display Out of Stock for relevant SKUs by default - philcon93
- ℹ️ - Merge pull request #334 from matt-downs/hotfix/272. Decrease z-index on cart button - [philcon93](https:/...

