Conversation
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
JohanM84
left a comment
There was a problem hiding this comment.
I'm fine with this change, but @mrapson-netronome and @kuba-moo must also approve
|
The particular file modified by this patch (kernel/nfp_net_ctrl.h) the firmware copy of https://github.com/Netronome/nfp-drv-kmods/blob/master/src/nfp_net_ctrl.h. The usual process for changes that will be upsteamed is as follows:
Note that NFP_NET_META "7" has been assigned to NFP_NET_META_CONN_HANDLE. Overall, you are welcome to continue testing with a NFP_NET_META_XDP_META_LEN meta type, but this pull request can only be accepted once the driver side changes are accepted upstream. |
Thanks for the explanations @mrapson-netronome! A question for you and/or @kuba-moo. Is the https://github.com/Netronome/nfp-drv-kmods repository the source of truth for host driver or the linux kernel? (i.e., should I rebase my host-side patch on top of the nfp-drv-kmods repo or, the |
|
They should be in sync, if in doubt kernel is the source of truth. To be precise whatever exists in a released kernel (i.e. not a -rc release or someone's tree) is hard driver ABI, beyond that it's case-by-case, but David Miller's net-next tree usually takes precedence. |
This PR required by Netronome/nic-firmware#6