Removal of Humanizer Dependency#95
Open
Conversation
added 15 commits
October 14, 2019 12:01
Humanizer is also removed from project.
All Test ran and verified to succeed!
Fixed the wrong changes with the correct changes.
Removal of Humanizer Dependency code
Author
|
Ok, added few tests to verify the implementations and the behavior matches that of Humanizer. |
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 88.88% 89.13% +0.25%
==========================================
Files 115 118 +3
Lines 5642 5717 +75
Branches 497 513 +16
==========================================
+ Hits 5015 5096 +81
+ Misses 616 610 -6
Partials 11 11
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Testing status