Open
Conversation
Line 86 -
[self setValue:comment forExifKey:key];
This passes value as "comment" and Exifkey as "Key"
It calls following function
Line 110 -
- (void)setValue:(NSString *)key forExifKey:(NSString *)value {
[self.exifDictionary setObject:value forKey:key];
}
- Issue : In line 86 we have value as first parameter and key as second parameter , this must be same in line 110 but it is "reversed" so corrected function
- (void)setValue:(NSString *)value forExifKey:(NSString *)key {
[self.exifDictionary setObject:value forKey:key];
}
|
I found this bug too。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 86 -
[self setValue:comment forExifKey:key];
This passes value as "comment" and Exifkey as "Key"
It calls following function
Line 110 -
(void)setValue:(NSString *)key forExifKey:(NSString *)value {
[self.exifDictionary setObject:value forKey:key];
}
Issue : In line 86 we have value as first parameter and key as second parameter , this must be same in line 110 but it is "reversed" so corrected function
(void)setValue:(NSString *)value forExifKey:(NSString *)key {
[self.exifDictionary setObject:value forKey:key];
}