Rewind Unpause Configuration & Configurable Rewind Bind by 2-X · Pull Request #51 · NitrOP7674/FreeplayCheckpoint

2-X · 2024-06-12T20:28:34Z

screenshots

description

adds configuration for rewind unfreeze actions. users can enable/disable certain actions from unpausing rewind, as well as set custom thresholds for steer/pitch/throttle/roll.
adds configuration for the Rewind Input Method allowing uses to select from Steer/Throttle/Pitch/Roll as the analogue input to control the game state. i also added a threshold for this input

original issue

considerations

we should agree on default values
we should agree where this list appears on the settings page. currently it is at the top

…le certain actions from unpausing rewind, as well as set custom thresholds for steer/pitch/throttle/roll

…, not just at checkpoints

NitrOP7674

Thanks again for the PR. Sorry for the delay, and also sorry that I'm still going to be picky about all the new options being added that I don't think anyone really needs. I'm fine with leaving the vars if you feel very strongly that they need to be configurable (though I'd like to hear why you think you need it, since they add clutter to the code as well), but I'd rather remove them from the configuration UI for sure.

Can you also add something to the README to explain the new settings to control the rewind input method & matching axis bind, please?

NitrOP7674 · 2024-07-31T17:32:34Z

+9|Rewind Unpause Actions Configuration:
+1|Throttle Unpauses|enable_throttle_unpause
+4|Throttle Threshold|throttle_threshold|0.0|1.0
+1|Steer Unpauses|enable_steer_unpause
+4|Steer Threshold|steer_threshold|0.0|1.0
+1|Pitch Unpauses|enable_pitch_unpause
+4|Pitch Threshold|pitch_threshold|0.0|1.0
+1|Yaw Unpauses|enable_yaw_unpause
+4|Yaw Threshold|yaw_threshold|0.0|1.0
+1|Roll Unpauses|enable_roll_unpause
+4|Roll Threshold|roll_threshold|0.0|1.0
+1|Handbrake Unpauses|enable_handbrake_unpause
+1|Jump Unpauses|enable_jump_unpause
+1|Boost Unpauses|enable_boost_activate_unpause
+1|Boost Hold Unpauses|enable_boost_hold_unpause


Can we just delete all these, too? Why do you need to suppress rewind unpausing for anything besides the rewind and the other function on the same stick?

you're right i'll remove them

You deleted some but not all of these, I think. I think they should all go. If you really want to be able to configure them then I'm fine with leaving in the variables and allowing them to be set manually.

if you check the files i'm pretty sure i removed them all in the recent commit, hence the "Outdated" on the comment code here

Click on "files changed" and only 4 were removed. Let's delete the whole "Rewind Unpause Actions Configuration" section if you don't mind.

…nt that you make so history is preserved; remove unneeded config

2-X · 2024-07-10T17:15:33Z

+			if (axis == matchingAxis) {
+				effectiveThreshold = 0.9; // TODO customizable
+			}


i'm thinking since we have the thresholds already for all of the axes, this can be removed

2-X · 2024-07-31T21:45:32Z

+9|Rewind Unpause Actions Configuration:
+1|Throttle Unpauses|enable_throttle_unpause
+4|Throttle Threshold|throttle_threshold|0.0|1.0
+1|Steer Unpauses|enable_steer_unpause
+4|Steer Threshold|steer_threshold|0.0|1.0
+1|Pitch Unpauses|enable_pitch_unpause
+4|Pitch Threshold|pitch_threshold|0.0|1.0
+1|Yaw Unpauses|enable_yaw_unpause
+4|Yaw Threshold|yaw_threshold|0.0|1.0
+1|Roll Unpauses|enable_roll_unpause
+4|Roll Threshold|roll_threshold|0.0|1.0
+1|Handbrake Unpauses|enable_handbrake_unpause
+1|Jump Unpauses|enable_jump_unpause
+1|Boost Unpauses|enable_boost_activate_unpause
+1|Boost Hold Unpauses|enable_boost_hold_unpause


you're right i'll remove them

2-X · 2024-08-05T19:04:51Z

 		checkpoints.push_back(latest);
 		saveCheckpointFile();
-		loadGameState(latest);
+		// loadGameState(latest);


removing this line lets you set multiple checkpoints from the same play without erasing your history :)

Hmm, but then I'd be worried that people wouldn't realize they saved a checkpoint successfully, and that it would lead to people creating duplicate checkpoints. I think there would have to be some kind of feedback. Let's leave that out of this PR and consider something around it for the future.

hmmm sure i'll put it in it's own PR for sure! for that other PR, could we have it as an option? i really like this feature since i can do one play and then save the key moments to practice each part 😍

I'm fine with an option for this, but we should make sure something is displayed when you save the checkpoint, and a second push of doCheckpoint like this should probably delete the new checkpoint. I.e.:

Rewinding...

cpt_do_checkpoint - Message appears: "Checkpoint saved. Press again to remove."

cpt_do_checkpoint again - Message appears: "Checkpoint removed."

NitrOP7674

Thanks for the quick updates. Looking much better now. :)

NitrOP7674 · 2024-08-06T05:24:53Z

 		checkpoints.push_back(latest);
 		saveCheckpointFile();
-		loadGameState(latest);
+		// loadGameState(latest);


Hmm, but then I'd be worried that people wouldn't realize they saved a checkpoint successfully, and that it would lead to people creating duplicate checkpoints. I think there would have to be some kind of feedback. Let's leave that out of this PR and consider something around it for the future.

NitrOP7674 · 2024-08-07T01:18:59Z

+9|Rewind Unpause Actions Configuration:
+1|Throttle Unpauses|enable_throttle_unpause
+4|Throttle Threshold|throttle_threshold|0.0|1.0
+1|Steer Unpauses|enable_steer_unpause
+4|Steer Threshold|steer_threshold|0.0|1.0
+1|Pitch Unpauses|enable_pitch_unpause
+4|Pitch Threshold|pitch_threshold|0.0|1.0
+1|Yaw Unpauses|enable_yaw_unpause
+4|Yaw Threshold|yaw_threshold|0.0|1.0
+1|Roll Unpauses|enable_roll_unpause
+4|Roll Threshold|roll_threshold|0.0|1.0
+1|Handbrake Unpauses|enable_handbrake_unpause
+1|Jump Unpauses|enable_jump_unpause
+1|Boost Unpauses|enable_boost_activate_unpause
+1|Boost Hold Unpauses|enable_boost_hold_unpause


You deleted some but not all of these, I think. I think they should all go. If you really want to be able to configure them then I'm fine with leaving in the variables and allowing them to be set manually.

2-X changed the title ~~Rewind Unpause Configuration~~ Rewind Unpause Configuration & Configurable Rewind Bind Jun 13, 2024

NitrOP7674 reviewed Jul 6, 2024

View reviewed changes

add configuration for rewind unfreeze actions. users can enable/disab…

d63cbf5

…le certain actions from unpausing rewind, as well as set custom thresholds for steer/pitch/throttle/roll

2-X force-pushed the rewind-unpause-config branch from 6f19742 to d63cbf5 Compare July 10, 2024 16:46

2-X added 4 commits July 10, 2024 13:01

add minimum threshold for rewinding and always check for matchingAxis…

634ca51

…, not just at checkpoints

add rewind threshold option and remove hardcoded matching axis threshold

002c4b0

very nicee

0d8b4c6

normalize rewind input

ac7c082

NitrOP7674 reviewed Jul 31, 2024

View reviewed changes

remove gitignore; not atCheckpoint if rewinded; don't load a checkpoi…

6173ef6

…nt that you make so history is preserved; remove unneeded config

2-X commented Aug 5, 2024

View reviewed changes

NitrOP7674 reviewed Aug 7, 2024

View reviewed changes

unpause when rewinding at checkpoint

adcb390

Conversation

2-X commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

screenshots

description

original issue

considerations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NitrOP7674 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NitrOP7674 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

2-X commented Jun 12, 2024 •

edited

Loading