Skip to content

xen: add patch to fix hydra failure#333764

Merged
emilazy merged 1 commit into
NixOS:masterfrom
SigmaSquadron:xen-hydra-failure
Aug 10, 2024
Merged

xen: add patch to fix hydra failure#333764
emilazy merged 1 commit into
NixOS:masterfrom
SigmaSquadron:xen-hydra-failure

Conversation

@SigmaSquadron

@SigmaSquadron SigmaSquadron commented Aug 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of changes

  • Adds a patch to fix Xen Hydra builds by removing the redirection in the Figs Makefile.

Things done

  • Built on platform(s)
    • x86_64-linux
  • Tested, as applicable:
    • pkg-config test passes.
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 333764".
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • No release notes: change is minor.
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SigmaSquadron SigmaSquadron marked this pull request as draft August 10, 2024 20:04
@SigmaSquadron SigmaSquadron added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 10, 2024
@SigmaSquadron

SigmaSquadron commented Aug 10, 2024

Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 333764 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libvmi
  • qubes-core-vchan-xen
53 packages built:
  • qemu_xen (qemu_xen_4_19)
  • qemu_xen.debug (qemu_xen_4_19.debug)
  • qemu_xen.ga (qemu_xen_4_19.ga)
  • qemu_xen_4_16
  • qemu_xen_4_16.debug
  • qemu_xen_4_16.ga
  • qemu_xen_4_17
  • qemu_xen_4_17.debug
  • qemu_xen_4_17.ga
  • qemu_xen_4_18
  • qemu_xen_4_18.debug
  • qemu_xen_4_18.ga
  • xen
  • xen-guest-agent
  • xen-slim
  • xen-slim.boot
  • xen-slim.dev
  • xen-slim.doc
  • xen-slim.man
  • xen.boot
  • xen.dev
  • xen.doc
  • xen.man
  • xenPackages.xen_4_16
  • xenPackages.xen_4_16-slim
  • xenPackages.xen_4_16-slim.boot
  • xenPackages.xen_4_16-slim.dev
  • xenPackages.xen_4_16-slim.doc
  • xenPackages.xen_4_16-slim.man
  • xenPackages.xen_4_16.boot
  • xenPackages.xen_4_16.dev
  • xenPackages.xen_4_16.doc
  • xenPackages.xen_4_16.man
  • xenPackages.xen_4_17
  • xenPackages.xen_4_17-slim
  • xenPackages.xen_4_17-slim.boot
  • xenPackages.xen_4_17-slim.dev
  • xenPackages.xen_4_17-slim.doc
  • xenPackages.xen_4_17-slim.man
  • xenPackages.xen_4_17.boot
  • xenPackages.xen_4_17.dev
  • xenPackages.xen_4_17.doc
  • xenPackages.xen_4_17.man
  • xenPackages.xen_4_18
  • xenPackages.xen_4_18-slim
  • xenPackages.xen_4_18-slim.boot
  • xenPackages.xen_4_18-slim.dev
  • xenPackages.xen_4_18-slim.doc
  • xenPackages.xen_4_18-slim.man
  • xenPackages.xen_4_18.boot
  • xenPackages.xen_4_18.dev
  • xenPackages.xen_4_18.doc
  • xenPackages.xen_4_18.man

@SigmaSquadron SigmaSquadron marked this pull request as ready for review August 10, 2024 21:06
@SigmaSquadron SigmaSquadron mentioned this pull request Aug 10, 2024
Merged
5 tasks
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 10, 2024
emilazy
emilazy approved these changes Aug 10, 2024
View reviewed changes

@emilazy emilazy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth trying.

You might want to think about deduplicating shared patches between versions, as it’s not unlikely there’ll end up being more of these?

Comment thread pkgs/applications/virtualization/xen/4.16/0001-xen-fig-geneneration-4.16.patch Outdated
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 10, 2024
@SigmaSquadron
xen: add patch to fix hydra failure
8a310ff 
Second time's the charm! We have a transient SIGPIPE error caused by the
Figs makefile. This seems to only be reproducible in some Hydra
machines. This patch can be upstreamed into Xen if it fixes the build
failures.

Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@SigmaSquadron

SigmaSquadron commented Aug 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

w.r.t deduplicating patches: I've been considering just adding them to generic.nix. I don't want to complicate this too much now; that's best left for another time. (and I have a code cleanup PR cooking, that will finally deprecate those weird withPrefetchedSources and withTools functions!)

@emilazy emilazy merged commit bbea627 into NixOS:master Aug 10, 2024
@SigmaSquadron SigmaSquadron deleted the xen-hydra-failure branch August 10, 2024 22:34
@SigmaSquadron

SigmaSquadron commented Aug 11, 2024

Copy link
Copy Markdown
Contributor Author

"so if a package works on one machine, it will also work on another."

At least the error is different. I hate using Hydra as a testing platform like this.

Most of the important builds are working, but end users might find themselves compiling their Xen. We can remove figs entirely, but building the HTML docs is quite nice, and I'm not sure we want to lose that.

@emilazy

emilazy commented Aug 11, 2024

Copy link
Copy Markdown
Member

Is the error different? Seems like the same SIGPIPE: make[2]: *** [Makefile:11: network-bridge.png] Broken pipe.

@SigmaSquadron

SigmaSquadron commented Aug 11, 2024

Copy link
Copy Markdown
Contributor Author

Yeah, it's the same SIGPIPE, but at least it presents itself as a SIGPIPE instead of the error code.

@SigmaSquadron SigmaSquadron mentioned this pull request Aug 11, 2024
Merged
6 tasks
@SigmaSquadron

SigmaSquadron commented Aug 11, 2024

Copy link
Copy Markdown
Contributor Author

Third time's the charm: #333948

@SigmaSquadron SigmaSquadron added the 6.topic: xen-project Issues and PRs related to the Xen Project Hypervisor. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy approved these changes

Assignees

No one assigned

Labels

6.topic: xen-project Issues and PRs related to the Xen Project Hypervisor. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SigmaSquadron @emilazy @wegank