xen: delete patching infrastructure, 4.19.0 -> 4.19.0-unstable-2024-11-12#355535
Merged
Conversation
`xl` needs a full path to the efirom executable. This does not fix the qemu-dm issue. A stubdom is still required. Reported-by: HeHongbo <hehongbo@mail.com> Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
- Migrates to the new platform declaration style. - Removes the separate output TODO, as it is an impossible task. - Removes some superfluous comments. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
github-actions
Bot
added
the
6.topic: xen-project
SigmaSquadron
added
1.severity: security
SigmaSquadron
requested review from
a team,
CertainLach,
digitalrane,
emilazy and
hehongbo
SigmaSquadron
force-pushed
the
push-leznytsvqigy
branch
from
121fd4e to
c80a3b2
Compare
Overengineered for no good reason, especially since upstream Xen recommends downstreams to use the latest stable branch anyway (instead of the pinned release revision) Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
SigmaSquadron
force-pushed
the
push-leznytsvqigy
branch
from
c80a3b2 to
e4ab3bf
Compare
emilazy
approved these changes
Nov 12, 2024
emilazy
left a comment
emilazy
left a comment
Member
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355535
x86_64-linux
⏩ 1 package marked as broken and skipped:
- qubes-core-vchan-xen
❌ 1 package failed to build:
- vagrant
✅ 64 packages built:
- appvm
- collectd
- diffoscope
- diffoscope.dist
- diffoscope.man
- docker-machine-kvm2
- fdroidserver
- fdroidserver.dist
- garble
- gnome-boxes
- guestfs-tools
- htcondor
- libguestfs
- libguestfs-with-appliance
- libguestfs-with-appliance.guestfsd
- libguestfs.guestfsd
- librenms
- libvirt
- libvirt-glib
- libvirt-glib.dev
- libvirt-glib.devdoc
- libvmi
- libvmi.dev
- libvmi.lib
- mgmt
- minikube
- multipass
- ocamlPackages.ocaml_libvirt
- perl538Packages.SysVirt
- perl538Packages.SysVirt.devdoc
- perl540Packages.SysVirt
- perl540Packages.SysVirt.devdoc
- python311Packages.guestfs
- python311Packages.guestfs.dist
- python311Packages.libvirt
- python311Packages.libvirt.dist
- python311Packages.xen
- python311Packages.xen.boot
- python311Packages.xen.dev
- python311Packages.xen.doc
- python311Packages.xen.man
- python312Packages.guestfs
- python312Packages.guestfs.dist
- python312Packages.libvirt
- python312Packages.libvirt.dist
- xen (python312Packages.xen)
- xen.boot (python312Packages.xen.boot)
- xen.dev (python312Packages.xen.dev)
- xen.doc (python312Packages.xen.doc)
- xen.man (python312Packages.xen.man)
- qemu_xen
- qemu_xen.debug
- qemu_xen.ga
- rubyPackages.ruby-libvirt
- rubyPackages_3_1.ruby-libvirt
- rubyPackages_3_2.ruby-libvirt
- rubyPackages_3_4.ruby-libvirt
- virt-manager
- virt-manager-qt
- virt-manager.dist
- virt-top
- virt-v2v
- virt-viewer
- xen-guest-agent
Member
|
Vagrant failure is a little scary, but seems unrelated. Building again just to check if it’s flaky. |
Contributor
Author
|
It's not flaky, but it is unrelated. Vagrant has been failing for a while. (#348938) |
Member
|
Oh, Hydra doesn’t even build it because it’s non‐Free. Yeah, merging. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the Xen room and #355434
(hopefully) fixes #350179
fixes CVE-2024-45818 (XSA 463)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review pr 355535". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
nope, despite the branch name, i'm still not using
jj. I thought it would be a funny reference to a certain discussion in the Nixpkgs contributions room.