Skip to content

python3Packages.plux: disable test incompatible with pytest 9#505983

Merged
NickCao merged 1 commit intoNixOS:masterfrom
nolith:plux-disable-test
Apr 3, 2026
Merged

python3Packages.plux: disable test incompatible with pytest 9#505983
NickCao merged 1 commit intoNixOS:masterfrom
nolith:plux-disable-test

Conversation

@nolith
Copy link
Copy Markdown
Contributor

@nolith nolith commented Apr 2, 2026

test_resolve_distribution_information fails with pytest >= 9.0.2 because
pytest now ships PEP 639 License-Expression metadata instead of the legacy
License field. Upstream pins pytest==8.4.1 in CI so they never hit this.

Upstream fix: localstack/plux#46

This unblocks localstack and localstack-ext.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

test_resolve_distribution_information fails with pytest >= 9.0.2 because
pytest now uses PEP 639 License-Expression metadata instead of the legacy
License field. Upstream pins pytest==8.4.1 in CI and has not encountered
this yet.

Upstream fix: localstack/plux#46
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Apr 2, 2026
@nolith
Copy link
Copy Markdown
Contributor Author

nolith commented Apr 2, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 505983
Commit: c284e4be6cf8f6b15d41ed3d1609b91f9ed8b315


x86_64-linux

✅ 10 packages built:
  • localstack
  • localstack.dist
  • python313Packages.localstack-ext
  • python313Packages.localstack-ext.dist
  • python313Packages.plux
  • python313Packages.plux.dist
  • python314Packages.localstack-ext
  • python314Packages.localstack-ext.dist
  • python314Packages.plux
  • python314Packages.plux.dist

aarch64-linux

✅ 10 packages built:
  • localstack
  • localstack.dist
  • python313Packages.localstack-ext
  • python313Packages.localstack-ext.dist
  • python313Packages.plux
  • python313Packages.plux.dist
  • python314Packages.localstack-ext
  • python314Packages.localstack-ext.dist
  • python314Packages.plux
  • python314Packages.plux.dist

x86_64-darwin

✅ 10 packages built:
  • localstack
  • localstack.dist
  • python313Packages.localstack-ext
  • python313Packages.localstack-ext.dist
  • python313Packages.plux
  • python313Packages.plux.dist
  • python314Packages.localstack-ext
  • python314Packages.localstack-ext.dist
  • python314Packages.plux
  • python314Packages.plux.dist

aarch64-darwin

✅ 10 packages built:
  • localstack
  • localstack.dist
  • python313Packages.localstack-ext
  • python313Packages.localstack-ext.dist
  • python313Packages.plux
  • python313Packages.plux.dist
  • python314Packages.localstack-ext
  • python314Packages.localstack-ext.dist
  • python314Packages.plux
  • python314Packages.plux.dist

Copy link
Copy Markdown
Contributor

@MiniHarinn MiniHarinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Apr 2, 2026
@NickCao NickCao added this pull request to the merge queue Apr 3, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 3, 2026
Merged via the queue into NixOS:master with commit 72b59c0 Apr 3, 2026
40 of 42 checks passed
@nolith nolith deleted the plux-disable-test branch April 21, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants