Aligning sasrec implementation with CIKM2020-S3Rec#5
Draft
iskbaga wants to merge 1 commit into
Draft
Conversation
iskbaga
force-pushed
the
sasrec-refactored
branch
5 times, most recently
from
4321511 to
03b1e49
Compare
iskbaga
force-pushed
the
sasrec-refactored
branch
from
03b1e49 to
2f7abfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align our SASRec implementation with baseline from TIGER paper (from S3-Rec - Zhou et al. CIKM '20, github.com/aHuiWang/CIKM2020-S3Rec):
tiger/modeling/models/sasrec.py- embedding layerNorm + dropout addedtiger/modeling/models/base.py- updated weight inittiger/modeling/dataset/samplers.py- negative sampling rejects items from user's historytiger/modeling/dataset/base.py-num_itemsto samplernotebooks/DatasetProcessing.ipynb- add_row_idxfor join determinismtiger/configs/sasrec_train_config.json- params to S3-Rec defaultstiger/train_sasrec.py- Adam (not AdamW) anddrop_last=False