fix: propagate attach() to child in adoptChild when parent is already attached#50
Open
nielsenko wants to merge 1 commit intoNorbert515:mainfrom
Open
fix: propagate attach() to child in adoptChild when parent is already attached#50nielsenko wants to merge 1 commit intoNorbert515:mainfrom
nielsenko wants to merge 1 commit intoNorbert515:mainfrom
Conversation
nielsenko
force-pushed
the
fix-adopt-child
branch
from
2dec62d to
0564726
Compare
… attached RenderObject.adoptChild() now calls child.attach(owner) when the parent already has a PipelineOwner. Without this, render objects inserted into an already-attached parent (e.g. after element tree reparenting) never get their owner set, breaking features like GestureDetector that create mouse annotations in attach(). Add regression tests covering direct, transitive, container mixin, and single-child mixin adoption scenarios.
nielsenko
force-pushed
the
fix-adopt-child
branch
from
0564726 to
50afd42
Compare
Contributor
Author
|
Rebased on 0.5.1 |
Contributor
Author
|
The fix was already landed in #46. You may want to include the tests remaining in this PR, but otherwise feel free to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes: #49