fix/api-server-cors-vary-origin (base: upstream/main)#3211
Closed
aydnOktay wants to merge 3 commits intoNousResearch:mainfrom
Closed
fix/api-server-cors-vary-origin (base: upstream/main)#3211aydnOktay wants to merge 3 commits intoNousResearch:mainfrom
aydnOktay wants to merge 3 commits intoNousResearch:mainfrom
Conversation
Contributor
Author
|
heyy sir check pls my prs @teknium1 |
Contributor
|
Thanks for this contribution, @aydnOktay! The security header hardening from this PR was already salvaged and merged into main. This is an automated hermes-sweeper review.
Closing this PR as the work is fully implemented on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small but effective security hardening to the OpenAI-compatible API server by setting the X-Content-Type-Options: nosniff header on all responses via middleware, preventing MIME sniffing in browsers and improving overall safety for web-based clients; it also includes a regression test to ensure the header is consistently present.