[train] Remove deprecated SGLang backend from skyrl/#1220
Merged
Conversation
Hard deprecation of the SGLang backend. Removes all SGLang-specific code paths, configurations, tests, CI references, docs, and example scripts from the skyrl/ package. The backend dispatching infrastructure remains so future backends can be added by forking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the SGLang backend from SkyRL, as it is no longer supported. The code changes include removing SGLang-related code and documentation, updating configurations to use vLLM, and modifying tests to reflect the removal of SGLang. Specifically, the changes involve removing SGLang as an option for the inference engine backend, updating documentation to reflect the change, and removing SGLang-related tests and code from the codebase.
CharlieFRuan
approved these changes
Feb 26, 2026
Collaborator
CharlieFRuan
left a comment
CharlieFRuan
left a comment
There was a problem hiding this comment.
thank you! Only 1 nit
skyrl/backends/skyrl_train/inference_engines/ray_wrapped_inference_engine.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the deprecated SGLang backend in the new
skyrl/package.Summary
inference_engines/and all referencesgenerator.inference_engine.backendparameter so that we can revisit this in the future and allow users forking SkyRL to easily experiment with other backends.pytest.mark.vllmused in tests to demarcate vllm specific tests. SkyRL now runs only one inference engine so this is not needed.