Wire in freshwater fluxes#244
Open
simone-silvestri wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a freshwater flux should add / remove volume so it is added as a forcing in the \eta equation. This is possible to have only when we have a free-surface following vertical discretization.
The salt fluxes change their interpretation in this case, they are no more virtual fluxes but corrections that account for the incoming / outgoing salt in the added / removed volume. Since rain and runoff have$S = 0$ the correction stays $F * S_o$ (Should be $F * (S_o - S_i)$ .
Depends on CliMA/Oceananigans.jl#5592