Fix: Make files ref iterable when exposed via defineExpose#40
Draft
Copilot wants to merge 7 commits into
Draft
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: NyllRE <52743522+NyllRE@users.noreply.github.com>
Co-authored-by: NyllRE <52743522+NyllRE@users.noreply.github.com>
…xpose Co-authored-by: NyllRE <52743522+NyllRE@users.noreply.github.com>
Co-authored-by: NyllRE <52743522+NyllRE@users.noreply.github.com>
Co-authored-by: NyllRE <52743522+NyllRE@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] files is not iterable ٥:٣٨:٤٠ م
Fix: Make files ref iterable when exposed via defineExpose
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
defineExposeto expose thefilesref from a child component, users encountered the error "files is not iterable" and had to use awkward double.valueunwrapping:Solution
Made the
filesref iterable by addingSymbol.iteratorto it. Users can now iterate directly without the second.value:Implementation
Added a
createIterableRef<T>()helper function that:Symbol.iteratorproperty usingObject.definePropertyBackward Compatibility
✅ 100% backward compatible - all existing code continues to work:
files.valuestill returns the arrayfiles.value[index]still works.value.valueaccess still supportedTesting
All tests passing (5/5 ✅):
.valueAdditional Changes
test/composable.test.ts,test/define-expose.test.ts)Fixes #[issue_number]
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.