[16.0][FIX] rma_repair: correct visibility logic for RMA smart button#570
Open
nicolas-delbovier-acsone wants to merge 1 commit into
Open
[16.0][FIX] rma_repair: correct visibility logic for RMA smart button#570nicolas-delbovier-acsone wants to merge 1 commit into
nicolas-delbovier-acsone wants to merge 1 commit into
Conversation
Contributor
|
Hi @peluko00, |
The RMA smart button used an 'invisible' condition checking for 'rma_ids' = False. In Odoo, relational fields (One2many/Many2many) return an empty recordset rather than False, causing the button to remain visible even when empty. This commit: - Adds a computed 'rma_count' field to the repair order model. - Updates the XML to use 'rma_count' for the 'invisible' attribute. - Improves UI feedback by displaying the record count within the stat button. (This follows a pattern for smart buttons that can be found in many other places)
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-rma_repair-rma-button
branch
from
672cc71 to
e6bec94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RMA smart button used an 'invisible' condition checking for 'rma_ids' = False. In Odoo, relational fields (One2many/Many2many) return an empty recordset rather than False, causing the button to remain visible even when empty.
This PR:
(This follows a pattern for smart buttons that can be found in many other places)