[18.0][IMP] rma_lot: Add quantity serial number validation when replace/return process

[victoralmau]

Add quantity serial number validation when replace/return process

Similar to OCA/sale-workflow#4336

Please @pedrobaeza and @pilarvargas-tecnativa can you review it?

@Tecnativa TT62586

[victoralmau]

Ping @pedrobaeza and @pilarvargas-tecnativa

[pedrobaeza]

I think returns should check in RMA/WH, and replaces, if it's other S/N, does it make sense to do the check?

[victoralmau]

I think it's important (once again) to ensure data consistency, and that the replacement (out picking) wizard shouldn't allow users to select a kit that isn't available.

[pedrobaeza]

Yeah, I'm not saying the contrary, but to look in both locations for both operations seems not right.

[victoralmau]

Yeah, I'm not saying the contrary, but to look in both locations for both operations seems not right.

It's an interesting question, but so far I haven't found a better way to do it; regardless of the RMA location specified, depending on the routes and the settings for each one, stock will be drawn from one location or the other—or both—which is why the system checks both locations.

[pedrobaeza]

As the method is called from different places, you can distinguish the need from that calls, and only look on RMA/WH when returning, and the other when replacing.