[17.0][ADD] survey_question_type_model_selection: new module by eduezerouali-tecnativa · Pull Request #209 · OCA/survey

eduezerouali-tecnativa · 2025-12-16T11:07:17Z

This module extends the Survey question types by introducing a new question type that allows selecting records from any model, with configurable domain filters. This makes it possible to display dynamic, filtered model-based selections directly within surveys.

@Tecnativa TT59700

ping @pilarvargas-tecnativa @carlos-lopez-tecnativa @pedrobaeza

pilarvargas-tecnativa · 2025-12-18T19:25:02Z

It's perfect, except that even though the answers are correctly stored in the participation section, when you go to the review in the survey itself, you can't see them, only the questions.

For this, I want to remind you that you must add them to the view that is printed because, if I'm not mistaken, it checks the types to style them.

eduezerouali-tecnativa · 2025-12-31T10:31:52Z

You are right. Now is displaying correctly. Thank you for your review.

pedrobaeza · 2026-03-05T19:43:07Z

ping @pilarvargas-tecnativa

carlos-lopez-tecnativa · 2026-03-19T19:19:44Z

+                "survey_id": cls.survey.id,
+                "title": "State",
+                "question_type": "model",
+                "question_model_id": 81,


What does ID 81 correspond to? I think you should use the _get function instead of hardcoding the ID here,
like the default value self.env["ir.model"]._get_id("model.name").

carlos-lopez-tecnativa · 2026-03-19T19:26:57Z

+                <div
+                    class="col-sm-12 o_survey_choice_btn py-1 px-3 w-100 h-100 rounded mb-3"
+                >
+                <span t-out="answer_lines[0].value_model.display_name or None" />


I got this error when trying to print the survey.

This already fix, now it manages if it has no answer.

carlos-lopez-tecnativa · 2026-03-19T19:34:19Z

+        setTimeout(() => this._initAllInputs(), 100);
+        setTimeout(() => this._initAllInputs(), 500);
+        setTimeout(() => this._initAllInputs(), 1000);


I don't understand why we do the same thing with different intervals. Could you add a better comment or docstring?

Not really need it, it is done in this._setupObserver(); ,we need init the selection. becuse when DOM is display first time it is not load. I don't know if there is a more practical way of implementing it.

carlos-lopez-tecnativa · 2026-03-19T19:36:40Z

+            errorMsg.style.fontSize = "0.875rem";
+            errorMsg.style.marginTop = "0.25rem";
+            errorMsg.style.display = "none";
+            errorMsg.textContent = "Please select a valid option from the list";


I think this text can be translated.

Now it can be translated

eduezerouali-tecnativa · 2026-03-20T16:59:42Z

@carlos-lopez-tecnativa thanks to take the time for review this PR. I did attend your comments. It is ready for review again. Thank you.

carlos-lopez-tecnativa · 2026-03-25T18:52:19Z

+if (!applySurveyPatch()) {
+    let attempts = 0;
+    const maxAttempts = 50;
+    const interval = setInterval(() => {
+        attempts++;
+        if (applySurveyPatch()) {
+            clearInterval(interval);
+        } else if (attempts >= maxAttempts) {
+            clearInterval(interval);
+        }
+    }, 100);
+}


Why? Could you add a docstring to explain the reason for this code? It is not clear to me.
I imagine the DOM is not ready yet, but what is the actual reason?

carlos-lopez-tecnativa · 2026-03-25T19:10:40Z

+import publicWidget from "@web/legacy/js/public/public_widget";
+
+publicWidget.registry.SurveyModelInput = publicWidget.Widget.extend({
+    selector: ".js_surveyform, .o_survey_form, body",


I’m not sure if this code is loaded correctly. I attached a video where, if I start the survey from the test (or more specifically, if it displays the main page before starting the survey), it works fine. However, when I start the survey from a link from the Share wizard, it does not display the main page. The first question is loaded, but the input does not display the options. I suspect it is not loading correctly. Please take a look.

survey_question_type_model_selection.mp4

carlos-lopez-tecnativa · 2026-03-25T19:16:59Z

I see the code adds a feature to allow the user to select options, similar to a many2one field, which is nice, but what is the reason for implementing this here? Could an external library be used instead, such as Choices.js or Tom Select, etc?

pedrobaeza · 2026-03-25T19:20:11Z

For such simple feature, it's better to not add such maintenance burden.

eduezerouali-tecnativa · 2026-04-22T09:17:20Z

Add choices to it. Main changes apply:

Add choices lib.
survey_form.esm.js add choices + remove unnecessary code.
Templates match new select.
Tours adapted to select.

Changes do not affect following PR #210 #211
Also add @carlos-lopez-tecnativa as contributor as main reviewer.

please @pilarvargas-tecnativa @carlos-lopez-tecnativa could you review.

carlos-lopez-tecnativa

Tested functionally; it works. I left some technical comments to prevent mistakes.

Regarding the new library, it works fine, thanks. I didn’t request this as a change; it was just a question. If you decide to use an external library, that’s OK for me. Let’s see what @pedrobaeza thinks about this 😅

carlos-lopez-tecnativa · 2026-04-30T15:03:40Z

+    question_model_id = fields.Many2one(
+        string="Applies to",
+        comodel_name="ir.model",
+        default=lambda self: self.env["ir.model"]._get_id("res.partner"),
+        ondelete="cascade",
+    )


Please add a domain to prevent selecting models such as TransientModel and AbstractModel.

Because if a user selects a model like mail.thread, this causes an error in the frontend, and the domain is evaluated incorrectly.

carlos-lopez-tecnativa · 2026-04-30T15:08:35Z

+    _inherit = "survey.question"
+
+    question_type = fields.Selection(selection_add=[("model", "Model selection")])
+    question_model_id = fields.Many2one(


Take into account that if a user does not have permission to read ir.model (the group required to grant this access is Administration / Access Rights), they will get an error when trying to add a new question.

pedrobaeza · 2026-04-30T15:25:23Z

Yes, adding a JS library if there are more reasonable options is not the first choice (wordplay with the library name, hehe), and more if there are license incompatibilities (don't know the library license). What is that library bringing?

eduezerouali-tecnativa · 2026-04-30T17:17:41Z

It is a MIT https://github.com/Choices-js/Choices so there is not conflict using it. Is there any reason to add more code to have a custom many2one in the survey instead of using this library?

pedrobaeza · 2026-04-30T17:19:36Z

The reason is to not having to bundle a very heavy library inside the module, but if the ratio gain/pain doesn't worth, let's use the library.

This was referenced Dec 16, 2025

[17.0][ADD] survey_crm_generation_model_selection: new module #210

Open

[17.0][ADD] survey_contact_generation_model_selection: new module #211

Open

eduezerouali-tecnativa force-pushed the 17.0-add-survey_question_type_model_selection branch from 6a9e1c1 to 433d4bc Compare December 16, 2025 12:24

pedrobaeza requested a review from pilarvargas-tecnativa December 17, 2025 12:18

pedrobaeza added this to the 17.0 milestone Dec 17, 2025

eduezerouali-tecnativa force-pushed the 17.0-add-survey_question_type_model_selection branch 2 times, most recently from a197d13 to 366a795 Compare December 18, 2025 14:32

eduezerouali-tecnativa force-pushed the 17.0-add-survey_question_type_model_selection branch 2 times, most recently from 5b5422e to 82e6168 Compare December 31, 2025 10:24

eduezerouali-tecnativa force-pushed the 17.0-add-survey_question_type_model_selection branch 2 times, most recently from 613de04 to a60e05b Compare March 6, 2026 15:18

carlos-lopez-tecnativa suggested changes Mar 19, 2026

View reviewed changes

carlos-lopez-tecnativa reviewed Mar 19, 2026

View reviewed changes

eduezerouali-tecnativa force-pushed the 17.0-add-survey_question_type_model_selection branch 3 times, most recently from bc6ae2e to 6b79df2 Compare March 20, 2026 16:58

carlos-lopez-tecnativa suggested changes Mar 25, 2026

View reviewed changes

[ADD] survey_question_type_model_selection: new module

6f30609

eduezerouali-tecnativa force-pushed the 17.0-add-survey_question_type_model_selection branch from 6b79df2 to 6f30609 Compare April 22, 2026 09:05

OCA-git-bot added mod:survey_question_type_model_selection Module survey_question_type_model_selection series:17.0 labels Apr 22, 2026

carlos-lopez-tecnativa suggested changes Apr 30, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

eduezerouali-tecnativa commented Dec 16, 2025

Uh oh!

pilarvargas-tecnativa commented Dec 18, 2025

Uh oh!

eduezerouali-tecnativa commented Dec 31, 2025

Uh oh!

pedrobaeza commented Mar 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduezerouali-tecnativa commented Mar 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa commented Mar 25, 2026

Uh oh!

pedrobaeza commented Mar 25, 2026

Uh oh!

eduezerouali-tecnativa commented Apr 22, 2026

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Apr 30, 2026

Uh oh!

eduezerouali-tecnativa commented Apr 30, 2026

Uh oh!

pedrobaeza commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants