18.0 mig survey answer generation#224
Open
layadelcarmen wants to merge 14 commits into
Open
Conversation
Currently translated at 100.0% (16 of 16 strings) Translation: survey-17.0/survey-17.0-survey_answer_generation Translate-URL: https://translation.odoo-community.org/projects/survey-17-0/survey-17-0-survey_answer_generation/it/
OCA-git-bot
added
series:18.0
mod:survey_answer_generation
added 6 commits
May 28, 2026 10:08
Add four tests targeting previously uncovered branches: - _mark_done with no next_survey_input_id (outer if False) - _mark_done when partner already matches (inner condition False) - skipped choice answer sync (_get_line_answer_values suggestion with falsy suggested_answer_id and empty origin_line) - direct save to next_input with no origin line (non-suggestion origin_line False branch)
Add test for comment syncing on a choice question, the only question type that actually invokes _get_line_comment_values. The previous comment test used a char_box question whose base implementation routes through _save_line_simple_answer and never calls that method.
Author
|
@benbrich Check this out when you have a chance |
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.